You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After an initial report in #463, testing for #464 and a followup PR #468, I've concluded that composer autoloading needs to be completely removed from AS.
If you have two plugin active that are both configured to autoload a file named example.php only the example.php in the plugin that has its autoloader registered first will be autoloaded. Composer does not compare the files to determine whether they contain the same code. Instead, it assumes the files are duplicates.
If all plugins using AS updated to this configuration via composer then AS would not get initialized. The autoloader in the containing plugins would already have a class map for all the AS classes and the class_exists( 'ActionScheduler_Versions' ) check returns true
While this PR does correct the issue of initializing AS, the classmap(s) used are in the order that the plugin autoloaders are registered (thereby breaking the latest version logic). Since the functions.php isn't autoloaded, the functions.php used is from the latest registered version.
The text was updated successfully, but these errors were encountered:
After an initial report in #463, testing for #464 and a followup PR #468, I've concluded that composer autoloading needs to be completely removed from AS.
From #464:
If you have two plugin active that are both configured to autoload a file named
example.php
only theexample.php
in the plugin that has its autoloader registered first will be autoloaded. Composer does not compare the files to determine whether they contain the same code. Instead, it assumes the files are duplicates.Current AS configuration:
If all plugins using AS updated to this configuration via composer then AS would not get initialized. The autoloader in the containing plugins would already have a class map for all the AS classes and the
class_exists( 'ActionScheduler_Versions' )
check returns trueCode change in #468:
While this PR does correct the issue of initializing AS, the classmap(s) used are in the order that the plugin autoloaders are registered (thereby breaking the latest version logic). Since the
functions.php
isn't autoloaded, thefunctions.php
used is from the latest registered version.The text was updated successfully, but these errors were encountered: