Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove composer autoloading #472

Merged
merged 1 commit into from
Feb 25, 2020
Merged

remove composer autoloading #472

merged 1 commit into from
Feb 25, 2020

Conversation

rrennick
Copy link
Contributor

Fixes #471

This PR reverts all of 12daab2 plus the related code in e496d28.

Testing

  • Verify that AS loads correctly in the dashboard
  • Change the registered version to 3.1.1
  • Check the version being loaded in the WC system status report
  • Schedule a test action and allow it to process

@rrennick rrennick added this to the 3.1.1 milestone Feb 21, 2020
timmyc
timmyc approved these changes Feb 24, 2020
View reviewed changes
Copy link

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the version number in this line:

$versions->register( '3.1.1', 'action_scheduler_initialize_3_dot_1_dot_0' );

And verified the version being shown in the system status report was updated:

image

One minor question but otherwise this is looking good to me.

action-scheduler.php
@@ -40,14 +40,7 @@ function action_scheduler_register_3_dot_1_dot_0() {
}

function action_scheduler_initialize_3_dot_1_dot_0() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method name need to be changed at all to match the next version? 3.1.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method name need to be changed at all to match the next version? 3.1.1?

Yes, we do the version bump in its own PR #473.

@rrennick rrennick merged commit 04eb262 into master Feb 25, 2020
@rrennick rrennick deleted the issue_471 branch February 25, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmyc timmyc timmyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Remove composer autoloading
2 participants
@rrennick @timmyc