Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename invalid method name in ActionScheduler_wcSystemStatus #285

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Rename invalid method name in ActionScheduler_wcSystemStatus #285

merged 1 commit into from
Apr 15, 2019

Conversation

JPry
Copy link
Contributor

@JPry JPry commented Apr 15, 2019

Fixes #284.

This replaces ActionScheduler_wcSystemStatus::print() with a method named render(). It also implements the __call() magic method to allow for backwards-compatibility, since the print() function was public.

@JPry
Rename ActionScheduler_wcSystemStatus::print() to render()
59036b9 
Also provide backwards-compatibility via __call() magic method.
@JPry JPry requested a review from rrennick April 15, 2019 12:45
@JPry JPry requested a review from thenbrent April 15, 2019 13:17
rrennick
rrennick approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@rrennick rrennick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPry Looks & works great 🚢

@JPry JPry merged commit 081cde6 into master Apr 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the issue_284 branch April 15, 2019 14:26
@rrennick rrennick mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrennick rrennick rrennick approved these changes

@thenbrent thenbrent Awaiting requested review from thenbrent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid method name in system status class
2 participants
@JPry @rrennick