Fix marking actions with invalid schedules as failed #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenbrent
force-pushed
the
revert-297-fix/296
branch
from
80a3b81 to
4eea46e
Compare
thenbrent
force-pushed
the
revert-297-fix/296
branch
from
4eea46e to
44cf54f
Compare
|
I've rebased this one on |
rrennick
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
There is one call each to hook/unhook in the unit tests https://github.com/Prospress/action-scheduler/blob/version_3_0_0/tests/phpunit/jobstore/ActionScheduler_wpPostStore_Test.php#L57.
Once those are removed & the 3.0.0 changes, this is good to merge.
thenbrent
force-pushed
the
revert-297-fix/296
branch
from
44cf54f to
d3a690d
Compare
|
Thanks @rrennick! I've fixed up those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #297 because it would mark the action as failed every time it was fetched, which included things like every time an admin page loads to display the action. The desired behaviour is to mark the action as failed once, when an attempt to run it is undertaken (and that attempt fails). I will introduce that in a separate PR, because it relies on some other improvements to how exceptions are handled when failing to fetch the action.
Because the code from #297 has already been released, I've added a new
ActionScheduler_Store_Deprecatedclass to safely deprecate the public and protected methods being reverted.