Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php 7 deprecated notice for non static method called statically f… #355

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

scotteuser
Copy link

In php 7+ calling a method statically results in a php notice. WordPress calls the current screen help tabs statically so the help tab calls should be a static function to avoid this notice:

Deprecated: Non-static method ActionScheduler_AdminHelp::add_help_tabs() should not be called statically in /var/www/html/wp-includes/class-wp-hook.php on line 286

Thanks!

@thenbrent
Copy link
Contributor

This has been fixed in version_3_0_0 with SHA: dcf05de

For more background, see #335 (comment)

However, seeing as 3.0.0 is taking longer to release than originally expected, I'll merge this one into master for now too. Thanks for the patch @scotteuser!

@thenbrent thenbrent merged commit 9275e2b into woocommerce:master Aug 30, 2019
@scotteuser
Copy link
Author

Thanks! And good to know about version 3x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants