Update docs for version 3.0 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrennick
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
@thenbrent Thanks for updating this. This looks great other than the two item I notes so I'm pre-approving.
docs/api.md
Outdated
| ### Usage | ||
|
|
||
| ```php | ||
| as_enqueue_async_action( $hook, $hook, $args, $group ) |
There was a problem hiding this comment.
$hook parameter is duplicated.
docs/index.md
Outdated
|
|
||
| ### Housekeeping | ||
|
|
||
| Before processing a batch, the scheduler will remove any existing claims on actions which have been sitting in a queue for more than five minutes. | ||
| Before processing a batch, the scheduler will remove any existing claims on actions which have been sitting in a queue for more than five minutes (or more specifically, 10 times the allowed time limit, which defaults to 30 seconds). | ||
|
|
||
| Action Scheduler will also trash any actions which were completed more than a month ago. |
There was a problem hiding this comment.
were completed or canceled more than a month ago
* remove references to CPT usage * update Perf guide to provide warnings Fixes #411
|
I've fixed both of those up. Thanks for the review @rrennick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_enqueue_async_action()as_unschedule_all_actions()Fixes #411