Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register WooCommerce Navigation items (updated) #1802

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Register WooCommerce Navigation items (updated) #1802

merged 6 commits into from
Mar 24, 2021

Conversation

danielbitzer
Copy link
Contributor

I decided to take over the initial PR (#1698) to register WooCommerce nav items as there were merge conflicts and 2 newly added nav items that needed to be added. I had to open a new PR because the old one was from a fork branch.

Additionally I have hidden the existing tabbed navigation when the new Woo nav is active.

Screencast: with Woo nav enabled

Screencast: With Woo Nav disabled

Testing instructions

  1. Clone and install/activate https://github.com/woocommerce/woocommerce-admin
  2. Enable the navigation feature at wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  3. Check that the "Facebook" extension is registered and menu items work as expected.

Copy link
Contributor

@rcstr rcstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE! 💯

@danielbitzer danielbitzer deleted the wc-nav-items branch March 17, 2021 02:46
@danielbitzer danielbitzer restored the wc-nav-items branch March 17, 2021 23:55
@danielbitzer danielbitzer reopened this Mar 17, 2021
@danielbitzer
Copy link
Contributor Author

Note: this PR needs to be rebased onto a release branch since merging to master is not permitted.

@haszari haszari added type: enhancement The issue is a request for an enhancement. and removed enhancement labels Mar 22, 2021
@danielbitzer danielbitzer modified the milestones: 2.3.3, 2.3.4 Mar 24, 2021
@danielbitzer danielbitzer changed the base branch from master to release-2.3.4 March 24, 2021 06:33
@danielbitzer danielbitzer merged commit d177ccc into woocommerce:release-2.3.4 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed compatibility type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants