Syncs product with name in ALL CAPS and displays warning

[krutidugade]

Changes proposed in this Pull Request:

This PR enables syncing to Facebook for products with All Caps title. It adds a warning in the Facebook meta box on edit product page mentioning a potential synchronization issue and suggests changing it to sentence case.

Closes #2582.

Replace this with a good description of your changes & reasoning.

• Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Screenshots:

Detailed test instructions:

1. Clone the repo and checkout this branch
2. Add new product or edit existing product
3. Enter product name in All Caps
4. Enter dummy description
5. Click Update or Publish
6. You'll see "This product is not yet synced to Facebook." under Facebook meta box
7. Refresh the page
8. Verify Facebook meta box shows notice "Facebook ID: xxxxx may have issue with synchronisation as product title is all capital letters. Please change the title to sentence case to ensure product is synchronized."

Additional information:

If you leave the description blank, it will throw an exception showing a different notice. This will be addressed in separate report.

Changelog entry

Fix - Syncs products with All Caps title to Facebook and displays a warning in Facebook meta box.

[rawdreeg]

Thanks @krutidugade . LGTM! 👍🏾

[budzanowski]

Two things.

First. I think that the sentence that you propose is a bit vague. may have issues does not tell a lot to the merchant about the nature of the product.

Please consider a variant of:
Product title in all capital letters can lead to the server rejecting the product. To ensure successful product synchronization, please convert the product title to a sentence case.

Second.
Why show the sentence in case the product got synced? :) If we have the fb_product_id we should be good.

[budzanowski]

One more thing. Have you tested how it looks for a variation product with multiple variants?

[budzanowski]

Please check the comments and adjust.

[krutidugade]

Please consider a variant of:
Product title in all capital letters can lead to the server rejecting the product. To ensure successful product synchronization, please convert the product title to a sentence case.

Sure, this looks neat.

Why show the sentence in case the product got synced? :) If we have the fb_product_id we should be good.

Understood. I was under the impression that we want to sync the product and show the notice irrespective of the product being synced.

One more thing. Have you tested how it looks for a variation product with multiple variants?

No, I missed this part. The Variant IDs aren't generated. I'll look into this.

[budzanowski]

Understood. I was under the impression that we want to sync the product and show the notice irrespective of the product being synced.

This is my question basically. What should we do? I think that your proposal is the best option. I just want to be sure that we have thought about everything. Don't hesitate to question my thoughts and statements in case you feel or know that they are wrong.

[krutidugade]

This is my question basically. What should we do? I think that your proposal is the best option. I just want to be sure that we have thought about everything. Don't hesitate to question my thoughts and statements in case you feel or know that they are wrong.

Noted. I do think it is best we show the notice irrespective of the product being synced. In the following screenshot, we can see one variant isn't synced so the product wasn't synced properly.

I have updated the code. The notice can be seen after FB and variant IDs.