Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/clean up messenger references #2754

Merged
merged 2 commits into from
May 29, 2024

Conversation

layoutd
Copy link
Collaborator

@layoutd layoutd commented May 28, 2024

Changes proposed in this Pull Request:

Closes #2724.

This PR removes (nearly) all Messenger-related code to complete the process of Messgenger deprecation.

Detailed test instructions:

  1. Unit tests pass vendor/bin/phpunit (I get 3 skipped).
  2. Plugin works as usual with no errors
    1. Activate/deactivate plugin.
    2. Connect to a Facebook page. Smoke Test
    3. Product sync works Smoke Test.
    4. New product sync works Smoke Test.
  3. Test upgrade paths still work.
    1. Use a fresh WC install.
    2. Install Facebook for WooCommerce 1.11.4 and activate.
    3. Close any open browser windows, delete facebook directory, install Facebook for WooCommerce repo, swap to this branch, rebuild.
    4. Reopen /wp-admin/plugins.php and confirm current version 3.2.3 and no errors.
  4. Specifically test Messenger-related upgrade path.
    1. Use fresh WC install.
    2. Checkout repo, switch to branch <3.2.0
    3. Build and activate plugin, connect to Facebook page. Enable Messenger at /wp-admin/admin.php?page=wc-facebook&tab=messenger
    4. Checkout PR branch.
    5. Visit plugins page, confirm v3.2.3 shows, and no errors in logs.
    6. Confirm all Messenger related options were removed correctly
    SELECT *  FROM `wp_options` WHERE `option_name` LIKE '%facebook%messenger%';

Changelog entry

Tweak - Fully remove Facebook Messenger code references.

@layoutd layoutd self-assigned this May 28, 2024
@layoutd layoutd requested a review from a team May 28, 2024 22:02
Copy link
Contributor

@ibndawood ibndawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @layoutd. I followed your test instructions and the changes test well.

@layoutd layoutd merged commit 8965643 into develop May 29, 2024
5 checks passed
@layoutd layoutd deleted the remove/clean-up-messenger-references branch May 29, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully remove deprecated Messenger code
2 participants