Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also check store location before showing tax settings #313

Closed
jconroy opened this issue Mar 10, 2021 · 0 comments · Fixed by #491
Closed

Also check store location before showing tax settings #313

jconroy opened this issue Mar 10, 2021 · 0 comments · Fixed by #491
Assignees
@tomalec
Labels
merchant center type: bug The issue is a confirmed bug.

Comments

@jconroy
Copy link
Member

jconroy commented Mar 10, 2021

A follow up to #255

Screen Shot 2021-03-10 at 1 56 41 pm

Currently, we show the tax rate card only if a merchant is targeting the USA.

In reviewing some of the docs and discussing with @JPry it seems like probably should add a check to determine if the store location is also in the USA

We have some prior art for retrieving the store country in the front end here https://github.com/woocommerce/google-listings-and-ads/pull/289/files#diff-13063a0a3202fe1e5bcf850befb835a12f40288b655537521b1e13945f37bc62R34

Not a blocker, just something to tighten up while we are testing.
@jconroy jconroy added type: question The issue is a question about how code works. merchant center labels Mar 10, 2021
@jconroy jconroy added type: bug The issue is a confirmed bug. and removed type: question The issue is a question about how code works. labels Mar 22, 2021
@tomalec tomalec self-assigned this Apr 15, 2021
tomalec added a commit that referenced this issue Apr 15, 2021
@tomalec
Make useDisplayTaxRate check also store's country,
05a8b37 
but take a audience countries as an argument.

Stop exporting `shouldDisplayTaxRate` as nothing uses it any longer, YAGNI.

Fixes: #313.
@tomalec tomalec mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

Labels
merchant center type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make useDisplayTaxRate check also store's country woocommerce/google-listings-and-ads
2 participants
@tomalec @jconroy