Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust free campaigns setup and edit to redesigned "shipping rates and times" #335

Closed
tomalec opened this issue Mar 11, 2021 · 2 comments · Fixed by #778
Closed

Adjust free campaigns setup and edit to redesigned "shipping rates and times" #335

tomalec opened this issue Mar 11, 2021 · 2 comments · Fixed by #778
Assignees
Milestone

Comments

@tomalec
Copy link
Member

tomalec commented Mar 11, 2021

This is a follow-up issue from shipping rates and times

User story

@j111q:

Okay, here is the updated design for the "combined shipping rates and times": https://d.pr/i/aPCjIt

I tried to keep it as close to the original as possible, while still making it user-friendly - it IS an intimidating setting.
[…]
Appreciate any feedback or questions on the design though.

Screen Capture on 2021-03-10 at 17-40-21

Also, if this design change doesn't make it in for Tranche 2 (likely won't, since we're pushing for that this week), I think it's fine. We can just make a special note of it to testers and ask them to choose manual for both or neither.

Technical

We are in the middle of re-creating these components for Edit flow to be more reusable, and in the longterm used shared between onboarding end edit flows. On the meeting with @jconroy and me, we agreed to implement edit flow the "new way". It will introduce some inconsistency in the meantime, but since we are rewriting those components anyway, it would be a less wasted effort.

Figma link

https://www.figma.com/file/jZUpa8eTrnrK1Lwt2ry7zk/Native-Google-Integration?node-id=5918%3A172

@tomalec tomalec changed the title Adjust free campaigns setup and edit ro redesigned "shipping rates and times" Adjust free campaigns setup and edit to redesigned "shipping rates and times" Mar 11, 2021
@tomalec tomalec self-assigned this Mar 11, 2021
@tomalec
Copy link
Member Author

tomalec commented Mar 12, 2021

@j111q WDYT of using a smaller gap between Shipping rate & time cards?
Here is the example of half of the size.
image

That may suggest that all three cards are related to each other, and the forth card falls into a outer scope, just by looking at cards (Gestalt proximity)
image

@j111q
Copy link

j111q commented Mar 15, 2021

I like this suggestion, let's go with this! 👍 💯 Thanks for playing around with it @tomalec!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants