Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support paste verification #1106
Support paste verification #1106
Changes from 5 commits
ea14d6c
e1eef8e
2ad0673
875f05e
3837ca7
f5d4a6d
e37f3b7
555cfe3
0d0f771
d20faae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓
The meaning of this code comment is different from the
if ( digit !== value )
condition and its processing below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓
We don't need to handle content other than plain text. Not sure why it needs to use
onPaste
event? The samenewDigits
value could be got in the originalonInput
handler byI think this could simplify the processing of getting content from
onPaste
, and even further simplify other changes by using the originalhandleInput
to handle a 1 toDIGIT_LENGTH
length array of digits.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
The code comments are outdated after changing the position and implementation of the original
useEffect
.