-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blurb to inform users to connect Google Ads child account and not a parent MCC account #1359
Conversation
@j111q , please see the screenshots in the PR description above. It is a bit different from what we have in your design, specifically the text message goes over / above the "Connect" button (instead of having the same width as the drop down select control and having some empty space on the right). I make it that way to be consistent with the other cards, e.g. Switch URL Card. I hope that looks good. The design: The implemented UI: The design for Switch URL Card: |
Yup that's fine. Let me just update the Figma so it's consistent and I don't forget. Thanks for heads up Gan! 🙏 🚀 |
js/src/setup-ads/ads-stepper/setup-accounts/google-ads-account-card/connect-ads/index.scss
Outdated
Show resolved
Hide resolved
This is to make it consistent with other existing anchor styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, reviewed the code, LGTM.
Changes proposed in this Pull Request:
Closes #1346.
This PR adds a "blurb" or message to the UI to encourage users to only connect child Google Ads accounts, not manager account.
The message will only be displayed when there are more than one Google Ads account. Clicking on the "Learn more" link will log a track event:
Other technical notes:
AdsAccountSelectControl
so that it receivesaccounts
prop that is passed down fromNonConnected
component and doesn't need to rely onuseExistingGoogleAdsAccounts
hook.AdsAccountSelectControl
is only used inConnectAds
component. I have moved it from the shared components folder into the local folder together withConnectAds
.Screenshots:
When there is only one Google Ads account:
When there are more than one Google Ads account:
Clicking on the "Learn more" link will log a track event:
Detailed test instructions:
Note: to simulate a single Google Ads account or multiple Google Ads accounts, you can modify the following lines:
google-listings-and-ads/js/src/data/reducer.js
Lines 241 to 243 in e06e6c3
Changelog entry