Add E2E tests for the integration in the classic product editor #2363
Conversation
…inished onboarding
…upported product types
…fields for simple product
…le and variation products
…hiding in product catalog
…its notice, status, and issues
There was a problem hiding this comment.
Hey @eason9487, thanks for expanding the E2E tests to cover the classic product editor.
Tested the branch locally and confirmed tests are passing and expectations all look correct so LGTM ✅
tests/e2e/utils/product-editor.js
Outdated
| return page.locator( '.gla_attributes_multipack_field input' ); | ||
| }, | ||
|
|
||
| getAllProductAttributes( locator = page ) { |
There was a problem hiding this comment.
I see this function is almost the same as the getProductBlockEditorUtils version. Can we refactor it?
tests/e2e/utils/product-editor.js
Outdated
| const variableId = await api.createVariableProduct(); | ||
| await api.createVariationProducts( variableId ); |
There was a problem hiding this comment.
This can be refactored as well.
| adultContent, | ||
| } = editorUtils.getAllProductAttributes( locator ); | ||
|
|
||
| const allPairs = [ |
There was a problem hiding this comment.
This is duplicated with block-integration equivalent. Can we refactor it?
There was a problem hiding this comment.
Thanks @eason9487 for your work here.
The tests are passing and the code looking good for me.
I left some comments regarding possible refactors and preventing code duplication.
Approved in advance
…r` for reuse. Address: #2363 (comment)
…utils `product-editor` for reuse. Address: #2363 (comment)
…ub Actions." This reverts commit 253f16c.
Changes proposed in this Pull Request:
menu_orderproperties to the variations data intests/e2e/config/default.jsonto make them can be updated correctly via the classic product editor.📌 Checklist (@eason9487)
Detailed test instructions:
npm run devto build filesnpm run test:e2eto see if the E2E test in headless mode can pass.npm run test:e2e -- --uito inspect the E2E test in UI mode.Changelog entry