Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dev-related files from the build bundle #2367

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Exclude dev-related files from the build bundle #2367

merged 1 commit into from
Apr 15, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

This PR excludes dev-related files from the build bundle.

Detailed test instructions:

  1. Run npm run build
  2. Check if there are no more dev-related files bundled into google-listings-and-ads.zip.

Changelog entry

@eason9487 eason9487 requested a review from a team April 12, 2024 10:01
@eason9487 eason9487 self-assigned this Apr 12, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Apr 12, 2024
tomalec
tomalec approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup :) LGTM

@eason9487 eason9487 merged commit 7f6c4a4 into develop Apr 15, 2024
4 checks passed
@eason9487 eason9487 deleted the dev/update-export-ignore branch April 15, 2024 02:20
@ianlin ianlin mentioned this pull request Apr 16, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalec tomalec tomalec approved these changes

Assignees

@eason9487 eason9487

Labels
changelog: dev Developer-facing only change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @tomalec