Streamline onboarding: Clean up the access to the pre-launch checklist in the mc/settings API

[kt-12]

Changes proposed in this Pull Request:

This PR removed any backend related to a pre-launch checklist.

Closes #2494.

The PR addresses it's issue. Check screenshots section for after the change screenshots

Screenshots:

After:
All pre-launch checklist attributes removed from API

We are also able to move to last screen after the removal.

Detailed test instructions:

1. Switch to this branch and run build command npm run build
2. Delete gla_merchant_center saved options use npm run wp-env run cli wp option delete gla_merchant_center
3. On the 3rd screen, verify the Phone number (if not already), add the address(if not already), then press continue; it should take you to the next screen. You should also be able to perform the next steps and create a campaign successfully.

Additional details:

Changelog entry

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.2%. Comparing base (32bbb30) to head (c5c547a).

Additional details and impacted files

@@                              Coverage Diff                              @@
##             feature/2492-remove-pre-launch-checklist   #2555      +/-   ##
=============================================================================
+ Coverage                                        63.8%   65.2%    +1.4%     
- Complexity                                          0    4581    +4581     
=============================================================================
  Files                                             325     800     +475     
  Lines                                            5083   22899   +17816     
  Branches                                         1231    1230       -1     
=============================================================================
+ Hits                                             3241   14928   +11687     
- Misses                                           1674    7803    +6129     
  Partials                                          168     168              

Flag	Coverage Δ
js-unit-tests	63.8% <ø> (+0.1%)	⬆️
php-unit-tests	65.6% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../Controllers/MerchantCenter/SettingsController.php	97.6% <100.0%> (ø)
src/MerchantCenter/MerchantCenterService.php	95.0% <100.0%> (ø)

... and 488 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[mikkamp]

Just adding a note that the failing unit test is not related to this PR and is being resolved in #2559

[kt-12]

Just adding a note that the failing unit test is not related to this PR and is being resolved in #2559
@mikkamp Thank you for letting us know. @joemcgill Given that the unit test failure is unrelated, I am moving this to 10up CR now.

[joemcgill]

@kt-12 pointed out that after this is removed from the back-end, we may also want to clean up the settings where these are referenced in the SetupFreeListings component (ref)

[joemcgill]

Merging develop to this branch in e913578 has made reviewing this challenging, and trying to update all of the target branches that this will end up merging with is causing some merge conflicts. It's getting late in my day today, so I'm going to try to clean this up with fresher brain tomorrow.

[joemcgill]

Thanks @kt-12. This looks right to me.

In order to simplify the review and merging process, I restored this branch to commit 7b29364, prior to when you merged in develop and cherry-picked the two commits from #2559 so that the Unit Test will pass.

[joemcgill]

Changes are cherry picked from https://github.com/woocommerce/google-listings-and-ads/pull/2559/commits to fix unit test failures. This can be ignored.

[joemcgill]

Changes are cherry picked from https://github.com/woocommerce/google-listings-and-ads/pull/2559/commits to fix unit test failures. This can be ignored.

[ankitguptaindia]

QA/Test Report- ✅

Testing Environment -

• WordPress: 6.6.1
• Theme active on store: Storefront Version: 4.6.0
• WooCommerce - Version 9.2.3
• PHP: 8.3
• Web Server: Nginx
• Browser: Chrome - Version 127
• OS: macOS Sonoma 14.6

Test Results - The changes are working as expected. The pre-launch checklist items are no longer available. The user able to complete onboarding without any trouble. The console and error logs are clear during the onboarding steps.

Functional Demo / Screencast -

[mikkamp]

Thanks for the changes. I can confirm that the payload no longer has the additional fields:

{
  "shipping_rate": "automatic",
  "shipping_time": "flat",
  "tax_rate": "destination"
}

In the response they are also no longer being included:

{
    "status": "success",
    "message": "Merchant Center Settings successfully updated.",
    "data": {
        "shipping_rate": "automatic",
        "shipping_time": "flat",
        "tax_rate": "destination"
    }
}

If I refresh the page I can confirm that the setup status returns that onboarding is incomplete and on the paid_ads step:

{
  "status": "incomplete",
  "step": "paid_ads"
}

I left one comment about the unit test replacement as that's going to be confusing if revisited, so I'd suggest to commit a follow up change to fix the test.
Since the code is working as expected and the tests still pass I'll go ahead and mark this as approved.

[mikkamp]

One thing I wanted to mention here was that this test data is not a valid replacement. Because we no longer use the function checked_pre_launch_checklist the options are not fetched a fourth time.

We can confirm that by checking specifically for how many times it's called by using something like:

$this->options->expects( $this->exactly( 4 ) )->method( 'get' )

Which will fail with a message:

Expectation failed for method name is "get" when invoked 4 time(s).
Method was expected to be called 4 times, actually called 3 times.

So I'd suggest to actually check that it's invoked 3 times as well as remove the parameters and response for the fourth time.

		$this->options->expects( $this->exactly( 3 ) )->method( 'get' )
			->withConsecutive(
				[ OptionsInterface::MC_SETUP_COMPLETED_AT, false ],
				[ OptionsInterface::TARGET_AUDIENCE ],
				[ OptionsInterface::MERCHANT_CENTER, [] ]
			)->willReturnOnConsecutiveCalls(
				false,
				[
					'location'  => 'selected',
					'countries' => [ 'GB' ],
				],
				[]
			);

[joemcgill]

👍🏻 @kt-12 can you make these updates and request another review from me?

[kt-12]

Thank you @mikkamp and @joemcgill, I have addressed this comment.

[joemcgill]

The PHPUnit updates look right and tests are still passing. Since this was already approved I'm going to go ahead and merge.