Consolidate accounts onboarding: Temporarily remove Google Merchant Center and Google Ads account setup to facilitate the subsequent changes to the combo setup #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2458-consolidate-google-account-cards #2585 +/- ##
===============================================================================
Coverage ? 63.8%
===============================================================================
Files ? 327
Lines ? 5090
Branches ? 1232
===============================================================================
Hits ? 3248
Misses ? 1674
Partials ? 168
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5 tasks
joemcgill
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
I've left one non-blocking review comment, which we can clarify with @eason9487. Otherwise, I think this looks good. Thanks @dsawardekar!
| </StepContentFooter> | ||
| <Section | ||
| className="gla-google-mc-account-section" |
There was a problem hiding this comment.
Agree that renaming would be more appropriate.
There was a problem hiding this comment.
👍🏻 Added a note in the tracking ticket to remind us to come back to this.
QA/Test Report- ✅Test Results - Google Ads and MC are no longer appearing on the onboarding screen.
|
eason9487
approved these changes
Sep 9, 2024
| </StepContentFooter> | ||
| <Section | ||
| className="gla-google-mc-account-section" |
There was a problem hiding this comment.
Agree that renaming would be more appropriate.
eason9487
added
changelog: none
joemcgill
merged commit 465c090
into
feature/2458-consolidate-google-account-cards
7 checks passed
joemcgill
deleted the
update/2565-remove-google-mc-and-accounts-cards
branch
eason9487
added
changelog: update
eason9487
changed the title
eason9487
changed the title
eason9487
added a commit
that referenced
this pull request
Nov 21, 2024
…Google Merchant Center disclaimer. Address: #2585 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes the cards that are being reworked from setup-accounts.
Closes #2565
Screenshots:
Detailed test instructions:
Changelog entry