Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accounts onboarding: Connect to existing Google Ads account via the combo card #2640

Make label non interactive.

4cba145
Select commit
Loading
Failed to load commit list.
Merged

Consolidate accounts onboarding: Connect to existing Google Ads account via the combo card #2640

Make label non interactive.
4cba145
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

62.7% (+0.0%) compared to 7ceffde

View this Pull Request on Codecov

62.7% (+0.0%) compared to 7ceffde

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (7ceffde) to head (4cba145).

Files with missing lines Patch % Lines
js/src/components/account-card/index.js 77.8% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##           feature/2509-consolidate-google-account-cards   #2640   +/-   ##
=============================================================================
  Coverage                                           62.7%   62.7%           
=============================================================================
  Files                                                324     325    +1     
  Lines                                               5153    5162    +9     
  Branches                                            1259    1265    +6     
=============================================================================
+ Hits                                                3232    3239    +7     
- Misses                                              1744    1746    +2     
  Partials                                             177     177           
Files with missing lines Coverage Δ
js/src/components/app-select-control/index.js 88.9% <100.0%> (+0.7%) ⬆️
...gle-ads-account-card/connect-ads/connect-button.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 95.8% <100.0%> (-0.2%) ⬇️
js/src/components/account-card/index.js 91.9% <77.8%> (-4.9%) ⬇️