Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accounts onboarding: Merge the store address setting in Step 3 into Step 1 and remove Step 3 along with the phone verification #2653

Remove unused property

c77748c
Select commit
Loading
Failed to load commit list.
Merged
Codecov / codecov/project succeeded Nov 14, 2024 in 0s

61.5% (-1.2%) compared to 14c080e

View this Pull Request on Codecov

61.5% (-1.2%) compared to 14c080e

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.5%. Comparing base (14c080e) to head (c77748c).

Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                               @@
##           feature/2509-consolidate-google-account-cards   #2653     +/-   ##
===============================================================================
- Coverage                                           62.7%   61.5%   -1.2%     
===============================================================================
  Files                                                326     320      -6     
  Lines                                               5166    4934    -232     
  Branches                                            1266    1207     -59     
===============================================================================
- Hits                                                3239    3036    -203     
+ Misses                                              1751    1730     -21     
+ Partials                                             176     168      -8     
Files with missing lines Coverage Δ
js/src/components/account-card/index.js 89.2% <ø> (-2.7%) ⬇️
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/actions.js 8.6% <ø> (+0.7%) ⬆️
js/src/data/resolvers.js 7.1% <ø> (-0.5%) ⬇️
js/src/data/selectors.js 49.5% <ø> (+2.0%) ⬆️
.../src/setup-mc/setup-stepper/saved-setup-stepper.js 87.2% <ø> (-0.6%) ⬇️
js/src/setup-mc/setup-stepper/stepNameKeyMap.js 100.0% <ø> (ø)
js/src/utils/urls.js 52.6% <ø> (+0.1%) ⬆️

... and 1 file with indirect coverage changes