-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTIN] Adding more tests for GTIN migration #2679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add/support-core-gtin-field #2679 +/- ##
===============================================================
+ Coverage 64.9% 65.2% +0.3%
- Complexity 4670 4671 +1
===============================================================
Files 478 478
Lines 19529 19532 +3
===============================================================
+ Hits 12681 12735 +54
+ Misses 6848 6797 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these tests. They look good to me and they all pass as expected.
Based on the report here I noticed that we do not test migrating GTIN's from variable products, nor when an exception is thrown such as a duplicate GTIN.
Since migration is temporary I'm not too worried that this doesn't have full test coverage, but maybe we can at least log an issue with the missing tests.
# Conflicts: # src/Jobs/MigrateGTIN.php
Changes proposed in this Pull Request:
Closes part of #2617
Detailed test instructions:
Additional details:
Changelog entry