-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E admin login failure #2689
Fix E2E admin login failure #2689
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/connect-to-invalid-ads-id #2689 +/- ##
==================================================================
+ Coverage 62.3% 65.0% +2.8%
- Complexity 0 4656 +4656
==================================================================
Files 335 812 +477
Lines 5145 24573 +19428
Branches 1254 1254
==================================================================
+ Hits 3204 15984 +12780
- Misses 1769 8417 +6648
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit b0b35f3.
…erce/google-listings-and-ads into test/fix-e2e-admin-login-failure
Just to conclude, we found the culprit was the The following commit fixes this issue: c0fdbad Closing this PR, but it has some useful commits to help surface errors in the E2E environment: |
Created this draft PR to test E2E login on admin page. Not able to reproduce this failure locally.
Added screenshot recording to facilitate troubleshooting, this is what the login screen looks like: