Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak E2E tests supporting GTIN migration #2691

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Tweak E2E tests supporting GTIN migration #2691

merged 3 commits into from
Nov 22, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Nov 22, 2024

Changes proposed in this Pull Request:

  • Fixes E2E tests related to GTIN errors without depending on the release version.
  • Additionally adds a test for checking the GTIN field is visible but read-only for users that have the plugin installed <= 2.8.7

Screenshots:

Screenshot 2024-11-22 at 22 51 25

Detailed test instructions:

  1. Run the e2e tests locally and see them passing
  2. See GH E2E passing
  3. Set gla_install_version version as 2.8.7 and go to Product Page
  4. GTIN should be read only but visible
  5. Set gla_install_version version as 2.9.0 and go to Product Page
  6. GTIN should not be visible

Additional details:

Changelog entry

Dev - Tweak E2E tests for GTIN migration in versions > 2.8.7.

@puntope puntope self-assigned this Nov 22, 2024
@puntope puntope marked this pull request as ready for review November 22, 2024 19:05
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.7%. Comparing base (f17e3c0) to head (2af09e4).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2691   +/-   ##
=========================================
  Coverage       64.7%   64.7%           
  Complexity      4667    4667           
=========================================
  Files            799     799           
  Lines          24645   24645           
  Branches        1242    1242           
=========================================
  Hits           15944   15944           
  Misses          8528    8528           
  Partials         173     173           
Flag Coverage Δ
js-unit-tests 62.4% <ø> (ø)
php-unit-tests 65.3% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/HelperTraits/GTINMigrationUtilities.php 75.9% <100.0%> (ø)
---- 🚨 Try these New Features:

@puntope puntope merged commit 3975201 into develop Nov 22, 2024
15 checks passed
@puntope puntope deleted the fi/e2e-no-gtin branch November 22, 2024 19:09
@eason9487 eason9487 added the changelog: dev Developer-facing only change. label Nov 23, 2024
@ianlin ianlin mentioned this pull request Nov 26, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants