-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default destinations for Google products submission #287
Conversation
Thanks @nima-karimi
What was the error? |
You would need to create/link an ads account to your merchant account for that to start showing up. I have them both showing up: Although since this is setup for the product feed as a whole, I don't think it makes sense for us to set it per product. At least not in v1 where we include all products as free listings, and all products for a campaign (once they linked an ad account). If you are setting it per product then you would need to check if the user setup an ads account (which comes after syncing products in the onboarding process). As far as I can see |
I'm not sure it is set once per feed. When we first push a product to the MC via the content API a "Content API" feed is created automatically.
This may be me miss interpreting a conversation...
Perhaps we should be making sure to set eligibility within #255 |
@JamesAntisdel @Kheiden wanted to pull y'all into the convo - seems we've still got a little confusion about the appropriate approach for setting destinations. Should we...
Or be doing something else? |
I will need to confirm with @Kheiden but I think this may be optional for the products, i.e. you could leave it off for now to unblock. That said, I did test and got the following object to work for "included_destination" if you want to try. "includedDestinations": [ |
Also, if it helps, the object returns afterward like this: "includedDestinations": [ |
Thanks @JamesAntisdel - interesting I think docs we've seen have it listed as "Shopping Ads" - we can try with just "Shopping" as the value but if we can leave off then I guess we run with that.
It is listed as optional but I think we were wanting to make sure we have the ones we want covered to make sure |
I'll close this for now until we see it actually becoming an issue (the property is optional) |
Changes proposed in this Pull Request:
Closes #215.
This PR sets the
included_destination
field to a set of default constant values for all products:Shopping ads
andFree listings
.Question: I got a validation error from Google while submitting these two destinations. It's probably because I don't have the
Shopping ads
destination set in my product feed. But I can't set it anyways because there's no option butFree listings
there. Not sure what configuration should I make to include that destination.Detailed test instructions: