Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default destinations for Google products submission #287

Closed
wants to merge 1 commit into from

Conversation

nima-karimi
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #215.

This PR sets the included_destination field to a set of default constant values for all products: Shopping ads and Free listings.

Question: I got a validation error from Google while submitting these two destinations. It's probably because I don't have the Shopping ads destination set in my product feed. But I can't set it anyways because there's no option but Free listings there. Not sure what configuration should I make to include that destination.

Detailed test instructions:

  1. Sync all products or one product from the Connection Test page
  2. Check your Merchant Center after a few minutes and open the newly submitted product
  3. Check under the "Raw feed attributes" and make sure that both destinations are included

@nima-karimi nima-karimi requested a review from a team March 4, 2021 08:40
@nima-karimi nima-karimi self-assigned this Mar 4, 2021
@jconroy
Copy link
Member

jconroy commented Mar 4, 2021

Thanks @nima-karimi

I got a validation error from Google while submitting these two destinations.

What was the error?

@nima-karimi
Copy link
Contributor Author

What was the error?

It says to "Use a valid destination" 🤔

image

@mikkamp
Copy link
Contributor

mikkamp commented Mar 8, 2021

Question: I got a validation error from Google while submitting these two destinations. It's probably because I don't have the Shopping ads destination set in my product feed. But I can't set it anyways because there's no option but Free listings there. Not sure what configuration should I make to include that destination.

You would need to create/link an ads account to your merchant account for that to start showing up. I have them both showing up:
image

Although since this is setup for the product feed as a whole, I don't think it makes sense for us to set it per product. At least not in v1 where we include all products as free listings, and all products for a campaign (once they linked an ad account). If you are setting it per product then you would need to check if the user setup an ads account (which comes after syncing products in the onboarding process).

As far as I can see included_destination is optional and is combined with excluded_destination, so if that's set once per feed then wouldn't that be sufficient for our use case? Why is it necessary to set it to a set of defaults per product (some users might not setup an ad account till a lot later)?

@jconroy
Copy link
Member

jconroy commented Mar 8, 2021

set once per feed then wouldn't that be sufficient for our use case?

I'm not sure it is set once per feed. When we first push a product to the MC via the content API a "Content API" feed is created automatically.

Why is it necessary to set it to a set of defaults per product (some users might not setup an ad account till a lot later)?

This may be me miss interpreting a conversation...

The Merchant Center product feed has an attribute “included_destination”. I have pasted the documentation specific to the correct values and API docs below, e.g. Shopping ads and Free listings. Additionally, there are Account level Shipping settings that have destinations. We suggest eligibility of “All scenarios except Shopping Actions”.

Perhaps we should be making sure to set eligibility within #255

@jconroy
Copy link
Member

jconroy commented Mar 8, 2021

@JamesAntisdel @Kheiden wanted to pull y'all into the convo - seems we've still got a little confusion about the appropriate approach for setting destinations.

Should we...

  • not worry about setting the "included_destinations"
  • make sure we set eligibility on the shipping services we add?

Or be doing something else?

@JamesAntisdel
Copy link

I will need to confirm with @Kheiden but I think this may be optional for the products, i.e. you could leave it off for now to unblock. That said, I did test and got the following object to work for "included_destination" if you want to try.

"includedDestinations": [
"Shopping",
"Free Listings"
]

@JamesAntisdel
Copy link

Also, if it helps, the object returns afterward like this:

"includedDestinations": [
"Shopping",
"SurfacesAcrossGoogle"
]

@jconroy
Copy link
Member

jconroy commented Mar 9, 2021

Thanks @JamesAntisdel - interesting I think docs we've seen have it listed as "Shopping Ads" - we can try with just "Shopping" as the value but if we can leave off then I guess we run with that.

optional for the products,

It is listed as optional but I think we were wanting to make sure we have the ones we want covered to make sure

@jconroy jconroy requested review from a team and removed request for a team March 17, 2021 01:05
@jconroy
Copy link
Member

jconroy commented Mar 22, 2021

I'll close this for now until we see it actually becoming an issue (the property is optional)

@jconroy jconroy closed this Mar 22, 2021
@nima-karimi nima-karimi deleted the feature/set-included-destination branch March 29, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set included_​​destination on products
4 participants