Remove complete task option check

woocommerce · Oct 19, 2021 · ea433e4 · ea433e4
1 parent 0044fea
commit ea433e4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/client/header/activity-panel/index.js b/client/header/activity-panel/index.js
@@ -121,11 +121,11 @@ export const ActivityPanel = ( { isEmbedded, query, userPreferencesData } ) => {
 	const {
 		hasUnreadNotes,
 		hasAbbreviatedNotifications,
+		isCompletedTask,
 		thingsToDoNextCount,
 		requestingTaskListOptions,
 		setupTaskListComplete,
 		setupTaskListHidden,
-		trackedCompletedTasks,
 		previewSiteBtnTrackData,
 	} = useSelect( ( select ) => {
 		const { getOption } = select( OPTIONS_STORE_NAME );
@@ -154,9 +154,18 @@ export const ActivityPanel = ( { isEmbedded, query, userPreferencesData } ) => {
 				( list ) => list.id === 'setup' && list.isComplete
 			),
 			setupTaskListHidden: isSetupTaskListHidden,
-			trackedCompletedTasks:
-				getOption( 'woocommerce_task_list_tracked_completed_tasks' ) ||
-				[],
+			isCompletedTask: Boolean(
+				query.task &&
+					taskLists.reduce( ( value, list ) => {
+						return (
+							value ||
+							list.tasks.find(
+								( task ) =>
+									task.id === query.task && task.isComplete
+							)
+						);
+					}, false )
+			),
 			previewSiteBtnTrackData: getPreviewSiteBtnTrackData(
 				select,
 				getOption
@@ -343,7 +352,7 @@ export const ActivityPanel = ( { isEmbedded, query, userPreferencesData } ) => {
 			task &&
 			highlightShown !== 'yes' &&
 			( startedTasks || {} )[ task ] > 1 &&
-			! trackedCompletedTasks.includes( task )
+			! isCompletedTask
 		) {
 			return true;
 		}

diff --git a/client/header/activity-panel/test/index.js b/client/header/activity-panel/test/index.js
@@ -264,7 +264,7 @@ describe( 'Activity Panel', () => {
 				requestingTaskListOptions: false,
 				setupTaskListComplete: false,
 				setupTaskListHidden: false,
-				trackedCompletedTasks: [ 'payment' ],
+				isCompletedTask: true,
 			} ) );
 
 			const { queryByText } = render(