Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Add Mercado Pago as default fallback payment gateway #7043

Merged
merged 5 commits into from
May 25, 2021
Merged

Add Mercado Pago as default fallback payment gateway #7043

merged 5 commits into from
May 25, 2021

Conversation

joshuatf
Copy link
Contributor

@joshuatf joshuatf commented May 21, 2021 •
edited
Loading

Fixes (part of) #6855

  • Adds Mercado Pago to fallback gateways.
  • Moves help text above submit buttons.

Screenshots

Screen Shot 2021-05-21 at 12 43 45 PM

Detailed test instructions:

  1. Install this branch of Mercado Pago. https://github.com/woocommerce/woocommerce-gateway-mercadopago/pull/5
  2. Delete any remote payment transients.
  3. Check that the Mercado Pago payment gateway recommendation is shown.
  4. Check that the help text is correctly loaded.

@joshuatf joshuatf requested a review from a team May 21, 2021 16:46
@joshuatf joshuatf self-assigned this May 21, 2021
@psealock
Copy link
Collaborator

/wp-json/wc/v3/payment_gateways/mercadopago is failing with "message": "Resource does not exist.". However, /wp-json/wc/v3/payment_gateways/woo-mercado-pago-custom does work. Are we sending the wrong id?

@psealock psealock added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels May 25, 2021
@joshuatf joshuatf force-pushed the add/6855-paystack branch 2 times, most recently from 2a3718b to 63a0f97 Compare May 25, 2021 15:20
Base automatically changed from add/6855-paystack to main May 25, 2021 15:41
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team May 25, 2021 16:14
@joshuatf joshuatf mentioned this pull request May 25, 2021
Open
@joshuatf
Copy link
Contributor Author

@psealock I think I know what's happening. I cloned the repo into the woocommerce-mercadopago folder in the plugins directory. If your cloned folder name is different, it will attempt to install from the WP.org repo.

But it appears the repo I was using was the incorrect one anyway and you're correct on the gateway ID needing to be updated to match that ID. Opened a new branch here and update the ID in this PR.

When you clone that branch, make sure to clone it to woocommerce-mercadopago so you don't get two plugins.

@joshuatf joshuatf added status: needs review and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels May 25, 2021
joelclimbsthings
joelclimbsthings approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what @psealock said, this is working just fine on my end 👍🏻

psealock
psealock approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to the gateway with woo-mercado-pago-custom is working and I have the Mercado branch changes in the correctly named folder now :prapproved:, this is all looking good.

@joshuatf joshuatf merged commit 9a9978d into main May 25, 2021
@joshuatf joshuatf deleted the add/6855-mercadopago branch May 25, 2021 22:09
ObliviousHarmony pushed a commit to woocommerce/woocommerce that referenced this pull request Mar 18, 2022
@joshuatf
Add Mercado Pago as default fallback payment gateway (woocommerce/woo…
f09b062 
…commerce-admin#7043)

* Add paystack to fallback payment gateways

* Add mercado page to fallback gateways

* Move help text above submit button

* Add changelog entry

* Update gateway ID
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelclimbsthings joelclimbsthings joelclimbsthings approved these changes

@psealock psealock psealock approved these changes

Assignees

@joshuatf joshuatf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuatf @psealock @joelclimbsthings