Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Create Header: Centered Search pattern #9035

Closed
Tracked by #8947
albarin opened this issue Apr 14, 2023 · 2 comments · Fixed by #9081
Closed
Tracked by #8947

Create Header: Centered Search pattern #9035

albarin opened this issue Apr 14, 2023 · 2 comments · Fixed by #9081
Assignees
Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.

Comments

@albarin
Copy link
Contributor

albarin commented Apr 14, 2023

Centered Search

Check Figma designs F5AAbRJOGbTeEweXPFtHgf-fi-1540_33086 for the latest updates and mobile views.

@albarin
Copy link
Contributor Author

albarin commented Apr 14, 2023

  • Language/currency switcher: there's no built-in language/currency support (only through external plugins), so I don't think we can do that part. Is it okay to remove it? (same as in Create Header: Simple Row pattern #9036)
  • Search block
    • The search icon/button cannot be changed, this is the close we can get right now 👇 Should we add to the block options to change the icon?
      Screenshot 2023-04-14 at 11 19 25
    • The input background color cannot be changed, should we implement it?
  • Customer account: currently only these two icon styles are available👇️ Is it ok to use the default one or should we add another option to match the designs? (same as in Create Header: Simple Row pattern #9036)
    Screenshot 2023-04-14 at 11 22 49
  • Mini Cart: the price and cart icon order is fixed: price on the left, cart on the right, should we add an option to switch the order? Also, the icon cannot be changed, there's an issue in the Mini Cart project to fix that, I think we should use the one we have for now.
    Screenshot 2023-04-14 at 11 25 14
  • Navigation menu: the separator between menu items / cannot be customized, is it ok to not include the /?

@albarin albarin added type: enhancement The issue is a request for an enhancement. focus: patterns WooCommerce patterns labels Apr 14, 2023
@albarin albarin changed the title Create Header 4 pattern Create Header: Centered Search pattern Apr 18, 2023
@albarin
Copy link
Contributor Author

albarin commented Apr 18, 2023

  • Language/currency switcher: there's no built-in language/currency support (only through external plugins), so I don't think we can do that part. Is it okay to remove it? (same as in Create Header: Simple Row pattern #9036)

    • Search block

      • The search icon/button cannot be changed, this is the close we can get right now 👇 Should we add to the block options to change the icon?
        Screenshot 2023-04-14 at 11 19 25
      • The input background color cannot be changed, should we implement it?
    • Customer account: currently only these two icon styles are available👇️ Is it ok to use the default one or should we add another option to match the designs? (same as in Create Header: Simple Row pattern #9036)
      Screenshot 2023-04-14 at 11 22 49

    • Mini Cart: the price and cart icon order is fixed: price on the left, cart on the right, should we add an option to switch the order? Also, the icon cannot be changed, there's an issue in the Mini Cart project to fix that, I think we should use the one we have for now.
      Screenshot 2023-04-14 at 11 25 14

    • Navigation menu: the separator between menu items / cannot be customized, is it ok to not include the /?

Design updated to solve all the above issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant