Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Create Header: Simple Row pattern #9036

Closed
Tracked by #8947
albarin opened this issue Apr 14, 2023 · 2 comments
Closed
Tracked by #8947

Create Header: Simple Row pattern #9036

albarin opened this issue Apr 14, 2023 · 2 comments
Assignees
@albarin
Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.

Comments

@albarin
Copy link
Contributor

albarin commented Apr 14, 2023 •
edited
Loading

Simple Row

Check Figma designs F5AAbRJOGbTeEweXPFtHgf-fi-1540_33046 for the latest updates and mobile views.
@albarin albarin mentioned this issue Apr 14, 2023
Closed
@albarin
Copy link
Contributor Author

albarin commented Apr 14, 2023 •
edited
Loading

  • Language/currency switcher: there's no built-in language/currency support (only through external plugins), so I don't think we can do that part. Is it okay to remove it?
  • Mini Cart: the product counter circle currently cannot be filled in black, is it important to work on this or should we just keep the current design? 👇
    Screenshot 2023-04-14 at 11 08 03
  • Search icon: the current search block does not allow showing only the magnifying glass, should we implement a custom one-off block for this pattern? If we should, what's the expected behavior when clicking on it?
  • Customer account: currently only these two icon styles are available👇️ Is it ok to use the default one or should we add another option to match the designs?
    Screenshot 2023-04-14 at 11 22 49

@albarin albarin mentioned this issue Apr 14, 2023
Closed
@albarin albarin added type: enhancement The issue is a request for an enhancement. focus: patterns WooCommerce patterns labels Apr 14, 2023
@albarin albarin mentioned this issue Apr 14, 2023
Closed
4 tasks
@albarin albarin self-assigned this Apr 14, 2023
@albarin albarin changed the title Create Header 2 pattern Create Header: Simple Row pattern Apr 18, 2023
@albarin
Copy link
Contributor Author

albarin commented Apr 18, 2023

  • Language/currency switcher: there's no built-in language/currency support (only through external plugins), so I don't think we can do that part. Is it okay to remove it?

    • Mini Cart: the product counter circle currently cannot be filled in black, is it important to work on this or should we just keep the current design? 👇
      Screenshot 2023-04-14 at 11 08 03

    • Search icon: the current search block does not allow showing only the magnifying glass, should we implement a custom one-off block for this pattern? If we should, what's the expected behavior when clicking on it?

    • Customer account: currently only these two icon styles are available👇️ Is it ok to use the default one or should we add another option to match the designs?
      Screenshot 2023-04-14 at 11 22 49

Design updated to solve all the above issues.

@albarin albarin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@albarin albarin

Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Patterns]: Add new Header: Simple Row pattern woocommerce/woocommerce-blocks
1 participant
@albarin