Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Price global styles leak into the Mini Cart #9044

Closed
Tracked by #8556 ...
Aljullu opened this issue Apr 14, 2023 · 0 comments · Fixed by #9276
Closed
Tracked by #8556 ...

Product Price global styles leak into the Mini Cart #9044

Aljullu opened this issue Apr 14, 2023 · 0 comments · Fixed by #9276
Assignees
Labels
block: mini-cart Issues related to the Mini-Cart block. block-type: product elements Issues related to Product Element blocks. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Apr 14, 2023

Styles added to the Product Price block are also applied to the Mini Cart product prices, which might be confusing and cause broken layouts.

To reproduce

  1. Go to Appearance > Editor > Template Parts and edit the Mini Cart template part.
  2. Now, open Styles > Blocks and search for the Product Price block.
  3. Change its styles, for example, setting a margin.
  4. Notice how the Mini Cart template part updates with those styles, making the layout look broken.
  5. Notice also the product price shown in the Mini Cart is not a block, so there is no way to select it and remove the applied global styles.

Expected behavior

Given that product prices shown in the Mini Cart are not blocks, global styles from the Product Price block should not be applied to them.

Screenshots

Enregistrament.de.pantalla.des.de.2023-04-14.12-09-09.webm
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. block-type: product elements Issues related to Product Element blocks. block: mini-cart Issues related to the Mini-Cart block. labels Apr 14, 2023
@Aljullu Aljullu self-assigned this Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. block-type: product elements Issues related to Product Element blocks. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
1 participant