Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Mini Cart block improvements #8556

Closed
29 of 39 tasks
Aljullu opened this issue Feb 27, 2023 · 1 comment
Closed
29 of 39 tasks

Mini Cart block improvements #8556

Aljullu opened this issue Feb 27, 2023 · 1 comment
Labels
block: mini-cart Issues related to the Mini-Cart block. type: epic A label used by Zenhub for indicating issues functioning as an Epic.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Feb 27, 2023 •
edited
Loading

This is an epic to track all Mini Cart block related issues that we want to look into. At the beginning of the project, there were 25 open issues in WC Blocks + 3 issues in other repos:

These issues need engineering, product or design decisions, so it might be a good idea to surface the feedback request early in the cycle so we aren't blocked:

Need design
Beta Give feedback
  2. Update header patterns containing the Customer Account block so they match the new block size woocommerce#42435
    block: customer account needs: design team: Kirigami & Origami type: bug type: good first issue
  3. Customizer: the mini cart icon is bold #7359
    block: mini-cart focus: global styles needs: design type: bug
    danieldudzic
  4. Mini Cart > alternative icons #6868
    block: mini-cart needs: design type: enhancement
    danieldudzic

Ready to be worked on
Beta Give feedback
  1. "Edit Mini Cart template part" link doesn't work in latest version of Gutenberg #8572
    block: mini-cart type: bug
    Aljullu
  2. Performance: Mini Cart block adds an additional ~40 requests on pages it is present. #7176
    block: mini-cart focus: performance
    Aljullu
  3. Icon + text scaling on Mini Cart and My Account block #8128
    block: mini-cart design review type: good first issue ▫️ pattern: headers
    albarin
  4. Mini cart shop button appearing differently in the editor vs the front end #7197
    block: mini-cart focus: global styles type: bug
    albarin
  5. Mini Cart drawer close button should inherit text color and be aligned properly #8603
    block: mini-cart type: bug
    Aljullu
  6. Mini cart badge has undefined as a classname #6977
    block: mini-cart type: bug type: good first issue
    albarin
  7. Selecting a block from the List view no longer switches views in Cart and Mini Cart #8148
    block: cart block: mini-cart type: bug
    mikejolley
  8. Editor: Mini Cart inner blocks have missing translations #8302
    block: mini-cart type: bug
    Aljullu
  9. Add border style controls to the Mini Cart overlay #6257
    block: mini-cart focus: global styles type: enhancement
    albarin
  10. Custom Mini Cart block contents get covered by the admin bar #6594
    block: mini-cart type: bug type: good first issue
  11. Explore ways to have a shared template part between Mini Cart and Cart blocks #7016
    block: cart block: mini-cart status: won't fix type: enhancement
    albarin
  12. Document which (inner) blocks are unlocked/removable and why woocommerce#42632
    block: cart block: checkout block: mini-cart focus: cart focus: checkout focus: documentation priority: normal team: Rubik
  13. Mini Cart block: preview only displays the icon, not the price #7750
    block: mini-cart type: bug type: good first issue
    roykho
  14. Mini Cart Block: Move away from using Modal component #8606
    block: mini-cart type: refactor type: technical debt
    Aljullu
  15. Mini-cart: add the option to change the style between 'Outline' and 'Default' in all the buttons #8787
    block: mini-cart type: enhancement
    albarin
  16. Mini Cart Contents block: add support for margin styles woocommerce#42431
    block: mini-cart focus: global styles status: blocked team: Rubik type: enhancement
  17. Mini Cart: allow customizing the drawer width #8814
    block: mini-cart focus: global styles type: bug
  18. If a user has modified the Mini Cart template part and the theme introduces a custom one, in the frontend the theme template takes precedence #8929
    block: mini-cart type: bug
    Aljullu
  19. [Mini Cart]: Change the Add to cart control to a toggle #8946
    Contributor Day - H1 2023 block: mini-cart type: enhancement type: good first issue
    Sidsector9
  20. "[Product name] is out of stock and cannot be purchased" notice should not be dismissible #8965
    block: cart block: mini-cart type: bug
  21. Product Price global styles leak into the Mini Cart #9044
    block-type: product elements block: mini-cart focus: global styles type: bug
    Aljullu
  22. Mini Cart Contents block buttons don't have the same styles in the editor and in the frontend #9048
    block: mini-cart focus: global styles type: bug
  23. When the Mini cart modal has a border, the close button should not be on top of it #8716
    Contributor Day - H1 2023 block: mini-cart focus: global styles type: bug
    Aljullu
  26. Mini Cart: Remove excessive margin under cart items #9051
    block: mini-cart focus: global styles type: bug
    Aljullu

Require work on Gutenberg
Beta Give feedback
  1. Mini Cart: only allow Mini Cart Contents block in the mini-cart template part woocommerce#42659
    block: mini-cart priority: normal status: blocked team: Rubik type: enhancement
    gigitux
  2. Template Parts and Mini Cart Contents Preview: vertical scrollbar is visible woocommerce#42482
    block: mini-cart status: blocked team: Rubik type: bug

Require work on WooCommerce
Beta Give feedback

In theory, we shouldn't need to do anything related to these issues, @Aljullu will review them again before project end date:

Repo cleanup (issues which might have been fixed before the project started)
Beta Give feedback
  1. Z-indexing on mini cart toolbar #7194
    block: mini-cart focus: global styles type: bug
  2. Mini Cart Button doesn't inherit style from theme #7522
    block: mini-cart focus: global styles type: enhancement
  3. Mini Cart does not display anything after adding products on AT sites #6874
    block: mini-cart needs feedback type: bug
  4. Mini Cart Block pop-out is blank when running Page Optimize Automattic/wp-calypso#65662
    Triaged User Report [Platform] Atomic [Pri] Normal [Type] Bug
  5. Mini Cart block: Cart showing blank with WooCommerce Subscriptions plugin active Automattic/wp-calypso#66683
    Triaged User Report [Platform] Atomic [Pri] High [Type] Bug
  6. Block themes: minicart doesn't allow users to checkout Automattic/wp-calypso#70204
    Mobile Web Triaged User Report [Closed] Resolved [Platform] Atomic [Pri] High [Type] Bug
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: mini-cart Issues related to the Mini-Cart block. and removed type: bug The issue/PR concerns a confirmed bug. labels Feb 27, 2023
@Aljullu Aljullu mentioned this issue Feb 27, 2023
Closed
@Aljullu Aljullu added the type: epic A label used by Zenhub for indicating issues functioning as an Epic. label Feb 28, 2023
@Aljullu Aljullu mentioned this issue Mar 2, 2023
Open
@Aljullu Aljullu mentioned this issue Apr 25, 2023
Closed
@Aljullu
Copy link
Contributor Author

Aljullu commented Apr 25, 2023

Superseded by #9198.

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
danieldudzic pushed a commit that referenced this issue May 23, 2023
Mini Cart: Add an icon setting with 3 alternative icon options. Closes …
7a1e0f3 
…#8556.
@danieldudzic danieldudzic mentioned this issue May 23, 2023
Merged
7 tasks
danieldudzic added a commit that referenced this issue Jun 12, 2023
@danieldudzic
Mini Cart: Add an alternative icon setting (#9570)
c9c72e5 
* Mini Cart: Add an icon setting with 3 alternative icon options. Closes #8556.

* Mini Cart: Fix Mini-cart icons in the toggle setting.

* Minor type fixes.

* Clean up type definitions.

* Move alt icon logic to a separate function.

* Fix cart icons sizes

* Add a negative margin to the mini cart icon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: mini-cart Issues related to the Mini-Cart block. type: epic A label used by Zenhub for indicating issues functioning as an Epic.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aljullu