-
Notifications
You must be signed in to change notification settings - Fork 219
Product Image Gallery block: Fix overflow when multiple images are used #10013
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +1.74 kB (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, it seems the image that you used is really small, and that is causing the image to stretch to occupy all the available space. I think it's going to take more time for me to investigate it, and test different scenarios, I'll continue tomorrow, Thank you for quickly reviewing this 🙌 . |
Hey @danieldudzic,
Considering that, I came up with the following solution:
Let me know what you think, or if you have a better solution than that. Right now, after testing multiple combinations of properties and values I couldn't figure out a simpler and better way to fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ed (#10013) * Fix Product Image Gallery block overflow when multiple images are used * Increase css specificity for the Product Image Gallery images * Fix whitespace * Fix style issue when using smaller images in the product image gallery
* Product Rating block > Ensure the customer reviews text is linked to the relevant reviews (#9998) * Fix reviews count not showing on Single Product page * Fix css style * Product Rating block: Ensure the Customer reviews text is linked to the relevant reviews when used within the Single Product Template. When used within the Single Product Block, the link directs the user to the product template. Additionally, clear out\ PHPCS warnings. * remove unnecessary call to wc_get_star_rating_html --------- Co-authored-by: Alexandre Lara <allexandrelara@gmail.com> * Product Rating block: Fix reviews count not showing on Single Product page (#9995) * Fix reviews count not showing on Single Product page * Fix css style * Single Product: Fix Product SKU not loading for different variations (#9990) * Single Product: Fix incorrect add to cart form markup (#9986) * Product Image Gallery block: Fix overflow when multiple images are used (#10013) * Fix Product Image Gallery block overflow when multiple images are used * Increase css specificity for the Product Image Gallery images * Fix whitespace * Fix style issue when using smaller images in the product image gallery * Empty commit for release pull request * update version * add testing instructions * update zip link * Product Rating: append #reviews on the Single Product Block (#10040) * Product Rating: append #reviews on the Single Product Block * refactor after feedback * fix version * update zip link * Single Product Block: avoid to register incompatibility blocks with the Single Product Block on the post/page editor (#10044) * update testing instructions * update zip link --------- Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com> Co-authored-by: Daniel Dudzic <daniel.dudzic@automattic.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Luigi <gigitux@gmail.com>
Description
Fix a bug that was causing images to overflow when using the Product Image Gallery block.
Walkthrough
🤖 Generated by Copilot at 5d8c36a
Fixes #9944
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Select an image with size 512 x 640 pixels
. Click on the "Set product image" button to confirm.WooCommerce Visibility
Performance Impact
Changelog