This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: refactor
The issue/PR is related to refactoring.
skip-changelog
PRs that you don't want to appear in the changelog.
category: tests
labels
Jun 29, 2023
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
June 29, 2023 13:10
gigitux
force-pushed
the
add/create-frontendUtils-class
branch
from
June 29, 2023 13:11
4fa8517
to
80dda99
Compare
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
…ocks into add/create-frontendUtils-class
…oocommerce/woocommerce-blocks into add/create-frontendUtils-class
4 tasks
Aljullu
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gigitux!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
type: refactor
The issue/PR is related to refactoring.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how the utils for the front end are structured. Gutenberg utils and other utils (
EditorUtils
andtemplateAPIUtils
) are already structured with a Page Object model approach. It makes sense that we follow the same approach for the frontend utilsTesting
Automated Tests
User Facing Testing
e2e tests should pass.