-
Notifications
You must be signed in to change notification settings - Fork 219
Fix Misplacement of Shipping Radio Buttons #10150
Conversation
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
Hey @masteradhoc, thank you for opening this PR! Please could you add some testing instructions for this, and please add before/after screenshots if possible since this is a visual change. We use these notes and screenshots in our release process so it's important to have them. By the way it's probably fine to copy the reproduction steps from the issue but change them to reflect the updates you've made. I'll review and run CI for this PR tomorrow. |
@opr Thanks. added instructions and the before image to showcase the issue. i'll need to run it though to get the After screenshot. Sorry missed that one earlier. if you can add it while your test would be great else i'll try end of the week to add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Nice work. It works for me, and CI is passing in #10291
I updated your description to show the after image, updated the last step of the testing notes, and also added a changelog entry.
Thanks again! 🥂
Fixes #10027
Testing Instructions
Screenshots
Changelog