Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Misplacement of Shipping Radio Buttons #10150

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Fix Misplacement of Shipping Radio Buttons #10150

merged 3 commits into from
Jul 20, 2023

Conversation

masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Jul 10, 2023

Fixes #10027

Testing Instructions

  1. Create any test site.
  2. Install and activate all the required plugins
  3. Add sample products.
  4. Add some Shipping methods.
  5. Create new test page.
  6. Add Cart block.
  7. Change two-column grid to stacked column using align option.
  8. Observe that "Shipping" radio buttons are not misaligned.

Screenshots

Before After
image image

Changelog

Fix an issue where the radio buttons for shipping methods were incorrectly aligned on the Cart block in the post and site editor.

@github-actions
Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 18, 2023
@ralucaStan ralucaStan requested review from a team and opr and removed request for a team July 19, 2023 15:15
@opr opr added type: bug The issue/PR concerns a confirmed bug. focus: blocks Specific work involving or impacting how blocks behave. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. block: cart Issues related to the cart block. and removed status: stale Stale issues and PRs have had no updates for 60 days. block: checkout Issues related to the checkout block. labels Jul 19, 2023
@opr
Copy link
Contributor

opr commented Jul 19, 2023

Hey @masteradhoc, thank you for opening this PR!

Please could you add some testing instructions for this, and please add before/after screenshots if possible since this is a visual change.

We use these notes and screenshots in our release process so it's important to have them.

By the way it's probably fine to copy the reproduction steps from the issue but change them to reflect the updates you've made. I'll review and run CI for this PR tomorrow.

@masteradhoc
Copy link
Contributor Author

@opr Thanks. added instructions and the before image to showcase the issue. i'll need to run it though to get the After screenshot. Sorry missed that one earlier.

if you can add it while your test would be great else i'll try end of the week to add it

Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Nice work. It works for me, and CI is passing in #10291

I updated your description to show the after image, updated the last step of the testing notes, and also added a changelog entry.

Thanks again! 🥂

@opr opr merged commit 7262a47 into woocommerce:trunk Jul 20, 2023
58 of 62 checks passed
@imanish003 imanish003 added this to the 10.8.0 milestone Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: blocks Specific work involving or impacting how blocks behave. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. type: community contribution
Projects
None yet
3 participants