This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix SearchListControl styles #10192
Merged
Fix SearchListControl styles #10192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
Aljullu
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Aljullu
force-pushed
the
fix/search-list-control-checkbox-styles
branch
from
5d5a54c
to
06f374b
Compare
Aljullu
changed the title
|
Size Change: +640 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
nefeline
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Nice work! 🚀
Confirmed that:
✅ In the placeholder, Clothing & Accessories is displayed.
✅ Verified that as I selected categories, the tags added to the "x categories selected" section have a gray background.
✅ Expanded a category with children categories and verified the checkboxes have the same size.
thealexandrelara
added
the
block: products by category
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some fixes to the SearchListControl component:
&will show up correctly (1883ef1).Fixes #9909.
Testing
User Facing Testing
&in its name. Ie:Clothing & Accessoriesand add at least one product to it.Clothing & Accessoriesis displayed, instead ofClothing & Accessories.WooCommerce Visibility
Changelog