This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add an endpoint for getting pay for order orders #10199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Register order route * Get order it * Add order schema * Check authorization for getting the order * Add order data to the response * Add order schema for the endpoint * Move validation check to order controller * Update the error codes * Add order item schema * Check if the order is associated with current user * Update order schema to match cart schema * Update order item schema to match cart item schema * Add product item trait * Update sold individually property * Allow guests to pay for order * Update wording for logged out customers * Allow getting all orders from the endpoint * Add inline explanation for pay_for_order capability * Remove unused $user_id and $order variables * Remove duplicate pay_for_order capability check from validate_order_key * Update exception wording when missing order id or key, or user mismatch * Ensure $order_key is not null to avoid fatal error when left blank * Resolve linting errors in order route class * Adjust order ID description * Create an abstract item schema * Remove unused properties * Remove unused properties * Add billing email validation * Allow to use the order endpoint in dev build only * Add order status property * Fix coupon and fee handling * Update documentation for feature flags * Update typo in total fees tax * Update typo in tax lines * Add missing payment methods to cart response --------- Co-authored-by: Mike Jolley <mike.jolley@me.com>
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
mikejolley
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Game the endpoints a quick check over too, looks good to go.
Thank you, @mikejolley ! |
imanish003
added
the
type: task
The issue is an internally driven task (e.g. from another A8c team).
label
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8922
This PR is to merge the feature branch
add/pay-for-order-flow
that includes add an endpoint for getting pay for order orders PR totrunk
.We have put the endpoint behind an experimental flag, so the
Add an endpoint for getting pay for order orders PR
should originally be merged totrunk
but I forgot to switch the branch from the feature branchadd/pay-for-order-flow
back totrunk
.Changelog