This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update express checkout title, description, icon #10237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexflorisca
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +536 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
tarunvijwani
approved these changes
Jul 20, 2023
| strokeWidth="1.5" | ||
| d="M18.25 12a6.25 6.25 0 1 1-12.5 0 6.25 6.25 0 0 1 12.5 0Z" | ||
| /> | ||
| <path fill="#1E1E1E" d="M10 3h4v3h-4z" /> |
There was a problem hiding this comment.
Just wondering if it's possible to utilize CSS variables here?
There was a problem hiding this comment.
Thanks for the suggestion. It's an SVG inside a JS file though so that won't work here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the title, description and the icon for the Express Checkout block after a design review. (AtfOeZIFizx7ASmoSUbNjD-fi-68_10433)
Fixes #10191
Screenshots
Note the capital C in Checkout in the block title, and the description and icon in the settings bar on the right
Before:
After:
Testing
User Facing Testing
WooCommerce Visibility
Changelog