This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Optimise imports of Product Query variation #10340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -804 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
kmanijak
added
focus: performance
7 tasks
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
nefeline
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #10267 I encountered a problem that Product Query logic was initialized twice in Editor and that included the subscription to the store changes here.
In scope of #10267 I subscribe to the
'core/block-editor'store changes and it's important to have singleunsubscribefunction returned from it. Unexpectedly the module was loaded twice and importing theunsubscribewas undeterministic.Product Query is marked with
sideEffecthence tree shaking is not applied when importingVARIATION_NAMEfrom Product Query variation file which happened withinclassic-template. So it actually included the whole module because of thesideEffects.This PR overcomes the problem by moving the variable to
constantswhich can be tree shaken when imported withinclassic-templateandproduct-querymodules.Summarizing this PR, it:
legacy-templatemoduleproduct-querymodule twice.Part of #9703
Testing
Automated Tests
User Facing Testing
console.log( 'Subscribing' )before the subscription happens inproduct-queryhere. (Adding breakpoint doesn't help here, as it's caught only once. I think it's because of the source maps that resolve to the single file anyway, hence the easiest is to actually useconsole.log).trunkWooCommerce Visibility
Performance Impact
It reduces the size of
legacy-templatemoduleChangelog