This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Refactor Store API hydration logic and prevent fatal errors from session class usage #10373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
focus: rest api
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Aug 1, 2023
nielslange
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the hydration logic so we have a shared service class for preloading requests. This shared service class handles removing nonces, and caching store notices only when a customer session object is present. This mitigates the issues in #10350.
Fixes #10350
Testing
Automated Tests
User Facing Testing
The original issue mentioned rendering blocks via cron jobs but I don't think this is easily testable. #10350 The check for
WC()->sessionbeingnullis the fix for this.WooCommerce Visibility
Changelog