This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Featured Items: Add selection button when id not found #10387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
block: featured category
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +207 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
The Select a category call to action button is displayed and works as expected :)
One small nitpick. I'd modify the changelog message slightly to indicate that this refers to the Featured Items blocks straight away and also add a full stop at the end.
Maybe something like the following:
Featured Items: Add a selection button when the item id is not found.
roykho
changed the title
imanish003
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10257
This PR adds a
call to actionbutton to allow user to re-select a featured item when the original saved ID is not found. Otherwise there is no way for the user to select an ID in a user friendly way.Screenshots
Testing
User Facing Testing
Featured Categoryblock to a page.Done.Code editormode and replace thecategoryIdto some random number that does not exists.Exit code editor.Sorry, an error occurred.Select a categorybutton and click it.WooCommerce Visibility
Performance Impact
Changelog