-
Notifications
You must be signed in to change notification settings - Fork 219
Featured Products: Fresh & Tasty pattern > Enhance mobile view and optimize images #10521
Featured Products: Fresh & Tasty pattern > Enhance mobile view and optimize images #10521
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.35 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nefeline, I'm getting this error when inserting the pattern
I think it's related to style="aspect-ratio:2/3;object-fit:cover"
on the images, are you getting it?
@albarin this is odd! I'm not able to reproduce this at all: Screen.Recording.2023-08-10.at.10.38.06.movI did a few extra tests here with WP 6.2.2, WP 6.3, and the GB plugin enabled/disabled, but no dice =/ Do you mind sharing the WP version & the plugins you have enabled locally? |
I just tried enabling/disabling GB. With WordPress 6.2.2 and GB disabled, I get the error. Once I enable GB it works fine. |
Thanks for sharing more details! I was able to reproduce with this setup. Updated 4355b12 I wonder if we should consider updating our version support policy from L0 to L1? Traditionally we have been developing and testing with the latest version of WordPress (and the new major upcoming version), but given the significant recent changes between versions 6.2.2 and 6.3, I think we should start being a bit more defensive. |
Maybe, it make sense to me, I guess that should be a wider team discussion, I saw you already asked on the channel 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
…-update-the-wrapping-on-mobile
Fixes #10519
Update the Featured Products: Fresh & Tasty pattern with the following changes:
Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Changelog