-
Notifications
You must be signed in to change notification settings - Fork 219
Prevent Sale badge overflowing the Product Image in some product grid blocks #11556
Conversation
The release ZIP for this PR is accessible via:
TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Size Change: +19 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @Aljullu! Thank you for addressing this issue! 🚀
I tested this in multiple themes and can confirm that it solves the issue for all of them. When I initially noticed this issue, it was occurring only when I selected the "Wide Width" or "Full Width" option for the Align setting on the Products Collection/On Sale Product blocks. Do you think we should include this step in the testing instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple yet brilliant!
Works correctly with TT4, TT3, TT2.
Thanks for the reviews!
Good point, I forgot to add it. I have just updated the testing instructions to include it, thanks for mentioning! |
What
Fixes #11438.
Why
This PR updates the CSS of the product grids to prevent the Sale badge not being properly aligned with the product image.
There is some more context in #11438.
Testing Instructions
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog