This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Collection: Hide filters in Inspector Controls depending on chosen Collection #11989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
changed the base branch from
trunk
to
add/10822-new-flow-for-product-collection
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/utils/address.ts
assets/js/blocks/product-collection/edit/product-collection-content.tsx |
|
Size Change: +404 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
kmanijak
changed the title
…23-hide-filters-per-collection
…23-hide-filters-per-collection
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
Closing. It's been moved to monorepo and included in the main PR: woocommerce/woocommerce#42696 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Hide some Product Collection filters in Inspector Controls based on the chosen Collection.
Note: This PR is created based on #10952 and is not targeting
trunkbutadd/10822-new-flow-for-product-collectionFixes woocommerce/woocommerce#42087
Why
Let's take New Arrivals as an example. What defines New Arrivals is the product order: from newest to oldest. Users can apply additional filters on top of it, for example, "On Sale" but shouldn't be able to change ordering because that would no longer be New Arrivals Collection.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog