Update dependency rules to enforce order and WooCommerce dependencies
#2775
Conversation
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
|
I still think external/woocommerce/internal is too many unnecessary groupings. But I care more about consistency across projects. Personally, I don't think we should make this decision isolated from other teams and it'd be worth a P2 to settle the question. |
| ], | ||
| "*.js": [ | ||
| "prettier --write", | ||
| "npm run lint:js" | ||
| "npm run lint:js -s" |
There was a problem hiding this comment.
🤔 I don't think I've seen the -s flag before (nor see it defined in the cli args list)
There was a problem hiding this comment.
Odd it worked... silent mode for npm to avoid all the error text added after the lint.
There was a problem hiding this comment.
ahhh, so an npm flag (not eslint) 👍
|
I started an internal discussion on creating a We'll keep this pull open in the meantime as I will use some of the code here in the custom plugin (and we can repurpose the pull to pull from the package when it's published). |
|
Just a heads up that I created a pull for adding a |
|
Unassigning myself. This can be closed when that other change is made I presume. |
|
We can close this now that woocommerce/woocommerce-admin#4714 is merged. |
This PR probably needs some debate due to the
WooCommercerule, but giving you the option :)@woocommercedependencies under their own sectionI've updated one file to check the rules pass.
Closes #2052
Note: WooCommerce admin uses this structure in it's dependencies too.