This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add pre-publishing script and bump version to 2.0.0-rc1 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will re-install dependencies, run linting on PHP, CSS, and JS, run the JS tests, and lastly build the production bundle.
ryelle
added
[Status] Needs Review
tools
ryelle
changed the title
timmyc
approved these changes
Mar 15, 2019
| @@ -16,9 +16,11 @@ | |||
| }, | |||
| "license": "GPL-3.0+", | |||
| "scripts": { | |||
| "prepack": "npm install && npm run lint && npm run test && npm run build", | |||
There was a problem hiding this comment.
I like the last safety check before the release, nice addition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is technically doing two things for the sake of speed– version bumping for 2.0.0-rc1, and adding some publishing helpers.
The
prepackscript is called whennpm packandnpm publishare run, and I've set it up to re-install dependencies, run linting on PHP, CSS, and JS, run the JS tests, and lastly build the production bundle. This basically checks everything one last time before making sure the build files are up to date. Then it builds the package to either a.tgzfile (pack), or pushes it to npm (publish).This means the only things needed to release a version is to do the version bump (manually, in
package.jsonandwoocommerce-gutenberg-products-block.php), and runnpm publishHow to test the changes in this Pull Request:
npm pack