This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Query: create variation of core/post-excerpt as a Product Query inner block
#7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prompt doesn't appear at the very bottom as there isn't currently any straightforward way to do this in the block variation. More investigation is required.
The order of the inspector controls is set in Gutenberg. We can hack our way down by hooking to the “color” group and display our feedback there. Other panels would be displayed below that if added, such as borders and margin.
We already had `atomic-blocks` but it wasn't resolving correctly in VSCode, although it was working as a module resolution. Adding this path also makes the import shorter. Eventually, we might want to remove `atomic-blocks` path resolver altogether, perhaps.
sunyatasattva
added
type: enhancement
sunyatasattva
changed the title
core/post-excerpt as a Product Query inner block
6 tasks
The prompt doesn't appear at the very bottom as there isn't currently any straightforward way to do this in the block variation. More investigation is required.
The order of the inspector controls is set in Gutenberg. We can hack our way down by hooking to the “color” group and display our feedback there. Other panels would be displayed below that if added, such as borders and margin.
We already had `atomic-blocks` but it wasn't resolving correctly in VSCode, although it was working as a module resolution. Adding this path also makes the import shorter. Eventually, we might want to remove `atomic-blocks` path resolver altogether, perhaps.
sunyatasattva
force-pushed
the
add/7735-core-post-title-variation
branch
from
825adb7 to
e2ed4ea
Compare
…post-excerpt-variation
|
The release ZIP for this PR is accessible via: |
|
Size Change: +234 B (0%) Total Size: 974 kB
ℹ️ View Unchanged
|
TypeScript Errors ReportFiles with errors: 430
assets/js/blocks/product-query/variations/elements/product-summary.tsx
|
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as we can, we should use core blocks when the functionality is mostly overlapping. In the case of the Post Title block, we don't need to add and maintain our own block most likely, so we should just brand the Post Title block instead.
This PR does the following:
Fixes #7835
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility