Ensure express payment buttons are visible next to each other #8548

nielslange · 2023-02-27T04:09:37Z

In p1677282265770279-slack-C02TS23QJ1, @c-shultz reported that the Express Payment buttons are not displayed next to each other when using the Tsubaki theme on a WorcPress.com site (using the eCommerce plan).

Screenshots

Before:	After:

Testing

User Facing Testing

Create a WordPress.com site using the eCommerce plan.
Install and activate the Tsubaki theme.
Install and activate WooCommerce Blocks using this ZIP file.
Install and activate WooCommerce Payments.
Install and activate WooCommerce Stripe Gateway.
Activate Express Payment both for WooCommerce Payments and WooCommerce Stripe Gateway.
Add a product to the cart and open the checkout page (which should use the Checkout block).
Verify that the Express Payment buttons are next to each other.
Install and activate the Storefront theme.
Verify that the Express Payment buttons are still next to each other and this PR does not introduce a regression.

Do not include in the Testing Notes

WooCommerce Visibility

WooCommerce Core
Feature plugin
Experimental

Changelog

Fix: Ensure that Epress Payment buttons are visible next to each other.

github-actions · 2023-02-27T04:11:46Z

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-8548.zip

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle	Added
`wc-blocks.js`	`wp-blocks`, `wp-compose`, `wp-element`, `wp-hooks`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`active-filters.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`all-products.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-escape-html`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`all-reviews.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`	⚠️
`attribute-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`breadcrumbs.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`cart.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-core-data`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-editor`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`catalog-sorting.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`checkout.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-core-data`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-editor`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`customer-account.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`featured-category.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`featured-product.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`filter-wrapper.js`	`wp-block-editor`, `wp-blocks`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`handpicked-products.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`legacy-template.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-data`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`mini-cart.js`	`react`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-dom`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`mini-cart-contents.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`store-notices.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`price-filter.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`product-best-sellers.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-category.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-categories.js`	`wp-block-editor`, `wp-blocks`, `wp-components`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`	⚠️
`product-new.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-on-sale.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-query.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-data`, `wp-element`, `wp-hooks`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`product-results-count.js`	`wp-block-editor`, `wp-blocks`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`product-search.js`	`wc-settings`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-element`, `wp-i18n`, `wp-polyfill`, `wp-primitives`	⚠️
`product-tag.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`product-top-rated.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`products-by-attribute.js`	`lodash`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-polyfill`, `wp-primitives`, `wp-server-side-render`, `wp-url`	⚠️
`rating-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`reviews-by-category.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`reviews-by-product.js`	`lodash`, `react`, `wc-settings`, `wp-api-fetch`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-element`, `wp-escape-html`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`single-product.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-escape-html`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`stock-filter.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-components`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

Files with errors: 490
Total errors: 2334

🎉 🎉 This PR does not introduce new TS errors.

_{comments-aggregator}

github-actions · 2023-02-27T04:18:34Z

Size Change: +6 B (0%)

Total Size: 1.1 MB

Filename	Size	Change
`build/wc-blocks-style-rtl.css`	26.7 kB	+3 B (0%)
`build/wc-blocks-style.css`	26.7 kB	+3 B (0%)

ℹ️ View Unchanged

Filename	Size
`build/active-filters-frontend.js`	7.98 kB
`build/active-filters-wrapper-frontend.js`	5.99 kB
`build/active-filters.js`	7.33 kB
`build/all-products-frontend.js`	11.7 kB
`build/all-products.js`	36.4 kB
`build/all-reviews.js`	7.67 kB
`build/attribute-filter-frontend.js`	22.4 kB
`build/attribute-filter-wrapper-frontend.js`	7.09 kB
`build/attribute-filter.js`	12.4 kB
`build/blocks-checkout.js`	41.2 kB
`build/breadcrumbs.js`	2.05 kB
`build/cart-blocks/cart-accepted-payment-methods-frontend.js`	1.38 kB
`build/cart-blocks/cart-cross-sells-frontend.js`	253 B
`build/cart-blocks/cart-cross-sells-products-frontend.js`	9.67 kB
`build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js`	5.19 kB
`build/cart-blocks/cart-express-payment-frontend.js`	720 B
`build/cart-blocks/cart-items-frontend.js`	299 B
`build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js`	5.35 kB
`build/cart-blocks/cart-line-items-frontend.js`	1.06 kB
`build/cart-blocks/cart-order-summary-frontend.js`	1.24 kB
`build/cart-blocks/cart-totals-frontend.js`	322 B
`build/cart-blocks/empty-cart-frontend.js`	345 B
`build/cart-blocks/filled-cart-frontend.js`	655 B
`build/cart-blocks/order-summary-coupon-form-frontend.js`	1.62 kB
`build/cart-blocks/order-summary-discount-frontend.js`	2.12 kB
`build/cart-blocks/order-summary-fee-frontend.js`	274 B
`build/cart-blocks/order-summary-heading-frontend.js`	455 B
`build/cart-blocks/order-summary-shipping-frontend.js`	14.8 kB
`build/cart-blocks/order-summary-subtotal-frontend.js`	275 B
`build/cart-blocks/order-summary-taxes-frontend.js`	434 B
`build/cart-blocks/proceed-to-checkout-frontend.js`	1.24 kB
`build/cart-frontend.js`	28.9 kB
`build/cart.js`	47.4 kB
`build/catalog-sorting.js`	1.7 kB
`build/checkout-blocks/actions-frontend.js`	1.85 kB
`build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js`	3.92 kB
`build/checkout-blocks/billing-address-frontend.js`	1.18 kB
`build/checkout-blocks/contact-information-frontend.js`	2.05 kB
`build/checkout-blocks/express-payment-frontend.js`	1.13 kB
`build/checkout-blocks/fields-frontend.js`	345 B
`build/checkout-blocks/order-note-frontend.js`	1.14 kB
`build/checkout-blocks/order-summary-cart-items-frontend.js`	3.67 kB
`build/checkout-blocks/order-summary-coupon-form-frontend.js`	1.78 kB
`build/checkout-blocks/order-summary-discount-frontend.js`	2.29 kB
`build/checkout-blocks/order-summary-fee-frontend.js`	276 B
`build/checkout-blocks/order-summary-frontend.js`	1.24 kB
`build/checkout-blocks/order-summary-shipping-frontend.js`	14.9 kB
`build/checkout-blocks/order-summary-subtotal-frontend.js`	275 B
`build/checkout-blocks/order-summary-taxes-frontend.js`	435 B
`build/checkout-blocks/payment-frontend.js`	8.42 kB
`build/checkout-blocks/pickup-options-frontend.js`	2.8 kB
`build/checkout-blocks/shipping-address-frontend.js`	1.14 kB
`build/checkout-blocks/shipping-method-frontend.js`	2.27 kB
`build/checkout-blocks/shipping-methods-frontend.js`	4.55 kB
`build/checkout-blocks/terms-frontend.js`	1.56 kB
`build/checkout-blocks/totals-frontend.js`	324 B
`build/checkout-frontend.js`	30.4 kB
`build/checkout.js`	44.2 kB
`build/customer-account.js`	3.08 kB
`build/featured-category.js`	13.3 kB
`build/featured-product.js`	13.6 kB
`build/filter-wrapper-frontend.js`	14 kB
`build/filter-wrapper.js`	2.4 kB
`build/general-style-rtl.css`	1.31 kB
`build/general-style.css`	1.31 kB
`build/handpicked-products.js`	7.24 kB
`build/legacy-template.js`	2.85 kB
`build/mini-cart-component-frontend.js`	28 kB
`build/mini-cart-contents-block/empty-cart-frontend.js`	366 B
`build/mini-cart-contents-block/filled-cart-frontend.js`	268 B
`build/mini-cart-contents-block/footer-frontend.js`	2.86 kB
`build/mini-cart-contents-block/items-frontend.js`	237 B
`build/mini-cart-contents-block/products-table-frontend.js`	589 B
`build/mini-cart-contents-block/shopping-button-frontend.js`	313 B
`build/mini-cart-contents-block/title-frontend.js`	367 B
`build/mini-cart-contents.js`	17.1 kB
`build/mini-cart-frontend.js`	2 kB
`build/mini-cart.js`	4.29 kB
`build/price-filter-frontend.js`	13.8 kB
`build/price-filter-wrapper-frontend.js`	6.98 kB
`build/price-filter.js`	8.39 kB
`build/price-format.js`	1.19 kB
`build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js`	253 B
`build/product-add-to-cart--product-button--product-image--product-rating--product-title.js`	151 B
`build/product-add-to-cart-frontend.js`	6.71 kB
`build/product-add-to-cart.js`	8.61 kB
`build/product-best-sellers.js`	7.6 kB
`build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js`	500 B
`build/product-button--product-image--product-price--product-rating--product-sale-badge--product-title.js`	259 B
`build/product-button-frontend.js`	2.19 kB
`build/product-button.js`	3.99 kB
`build/product-categories.js`	2.36 kB
`build/product-category-list-frontend.js`	1.19 kB
`build/product-category-list.js`	503 B
`build/product-category.js`	8.58 kB
`build/product-image-frontend.js`	2.2 kB
`build/product-image.js`	4.1 kB
`build/product-new.js`	7.58 kB
`build/product-on-sale.js`	7.91 kB
`build/product-price-frontend.js`	2.29 kB
`build/product-price.js`	1.58 kB
`build/product-query.js`	6.56 kB
`build/product-rating-frontend.js`	1.62 kB
`build/product-rating.js`	919 B
`build/product-results-count.js`	1.66 kB
`build/product-sale-badge-frontend.js`	1.43 kB
`build/product-sale-badge.js`	817 B
`build/product-search.js`	2.63 kB
`build/product-sku-frontend.js`	629 B
`build/product-sku.js`	378 B
`build/product-stock-indicator-frontend.js`	1.31 kB
`build/product-stock-indicator.js`	646 B
`build/product-summary-frontend.js`	1.58 kB
`build/product-summary.js`	920 B
`build/product-tag-list-frontend.js`	1.18 kB
`build/product-tag-list.js`	498 B
`build/product-tag.js`	8.06 kB
`build/product-title-frontend.js`	1.62 kB
`build/product-title.js`	3.46 kB
`build/product-top-rated.js`	7.82 kB
`build/products-by-attribute.js`	8.52 kB
`build/rating-filter-frontend.js`	20.9 kB
`build/rating-filter-wrapper-frontend.js`	5.61 kB
`build/rating-filter.js`	7.41 kB
`build/reviews-by-category.js`	11.2 kB
`build/reviews-by-product.js`	12.3 kB
`build/reviews-frontend.js`	7.14 kB
`build/single-product-frontend.js`	17.8 kB
`build/single-product.js`	9.98 kB
`build/stock-filter-frontend.js`	21.1 kB
`build/stock-filter-wrapper-frontend.js`	5.85 kB
`build/stock-filter.js`	8.13 kB
`build/store-notices.js`	1.69 kB
`build/vendors--attribute-filter-wrapper--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary--82e4ed06-frontend.js`	6.86 kB
`build/vendors--attribute-filter-wrapper--rating-filter-wrapper--stock-filter-wrapper-frontend.js`	7.69 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js`	5.26 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js`	19.4 kB
`build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js`	7.25 kB
`build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js`	3.14 kB
`build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js`	4.83 kB
`build/vendors--checkout-blocks/shipping-method-frontend.js`	12 kB
`build/vendors--checkout-blocks/shipping-methods-frontend.js`	8.84 kB
`build/wc-blocks-data.js`	21.4 kB
`build/wc-blocks-editor-style-rtl.css`	5.72 kB
`build/wc-blocks-editor-style.css`	5.73 kB
`build/wc-blocks-google-analytics.js`	1.56 kB
`build/wc-blocks-middleware.js`	933 B
`build/wc-blocks-registry.js`	3.15 kB
`build/wc-blocks-shared-context.js`	1.52 kB
`build/wc-blocks-shared-hocs.js`	1.73 kB
`build/wc-blocks-vendors-style-rtl.css`	1.96 kB
`build/wc-blocks-vendors-style.css`	1.96 kB
`build/wc-blocks-vendors.js`	64.4 kB
`build/wc-blocks.js`	2.63 kB
`build/wc-payment-method-bacs.js`	816 B
`build/wc-payment-method-cheque.js`	811 B
`build/wc-payment-method-cod.js`	909 B
`build/wc-payment-method-paypal.js`	837 B
`build/wc-settings.js`	2.6 kB
`build/wc-shipping-method-pickup-location.js`	29.7 kB
`build/woo-directives-runtime.js`	2.52 kB
`build/woo-directives-vendors.js`	7.91 kB

_{compressed-size-action}

pierorocca · 2023-02-27T05:29:32Z

Will this be deployed to both core and the blocks plugin?

mikejolley

Code change is okay 👍🏻 I don't think its necessary to go through the testing steps and setup a new site—your screenshot/testing should suffice.

nielslange · 2023-02-27T12:30:47Z

Will this be deployed to both core and the blocks plugin?

@pierorocca We'll deploy the fix both to WooCommerce core (should be shipped with WooCommerce 7.5 on March 14) and with WooCommerce Blocks 9.6.x and 9.7.0.

malithsen · 2023-02-27T16:49:08Z

Hi @nielslange Thanks for the fix!
I was testing this fix and noticed that when WooPay and Google Pay are enabled on WooCommerce Payments and Stripe Gateway is enabled, but Express Payments is disabled, there's an empty space visible. I see an empty li for Stripe's Google Pay button even when it's not enabled. I am unsure whether this should be fixed on Blocks or Stripe extension's end.

When more than two express buttons are available, we might want to add some spacing for the second row.

* Empty commit for release pull request * Add changelog in readme.txt * Add testing notes * Remove change from testing notes This requires AvaTax credentials for testing. So, we'll test for regressions instead * Check for null session before going forward (#8537) * Fix Payment Options settings crash in the editor (#8535) * Ensure express payment buttons are visible next to each other (#8548) * Update ZIP file * Bumping version strings to new version. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: Niels Lange <info@nielslange.de>

pierorocca · 2023-02-27T23:02:25Z

@elizaan36 can you provide guidance here please on IF a 2nd row should even be permissable here?

pierorocca · 2023-02-27T23:09:34Z

@stephendharmadi who has done some work on 3 button designs and corresponding widths.

stephendharmadi · 2023-02-28T13:14:59Z

Heyyaa, I have given my design input here woocommerce/woocommerce#42464

Please let me know if you have any questions!

* Empty commit for release pull request * Add changelog to readme.txt * Unset default customer state if it doesn't match country (#8460) * Unset default state * add controller for customers * rename validation file * explain fix inline * address feedback * revert back state logic * Update src/StoreApi/Utilities/ValidationUtils.php Co-authored-by: Mike Jolley <mike.jolley@me.com> --------- Co-authored-by: Mike Jolley <mike.jolley@me.com> * Update readme.txt * Add testing notes * Update testing notes * Fix Customer account sidebar link incorrect margin in WP 6.2 (#8437) * Fix Customer account sidebar link incorrect margin in WP 6.2 * Update class name to match the guidelines * Prevent cart from breaking when item_data contains an array (#8440) * Ensure array item data is removed * Remove unused key * Clean up code and add comments * Check for null instead of empty * Use plain foreach to filter and map arrays * Add minimum height to Mini Cart Contents block in the Style Book (#8458) * Update testing notes zip file * Update testing notes * Update testing notes file * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * disable compatibilty layer (#8507) * update changelog and testing instructions * add zip link * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * Add changelog in readme.txt * Add testing notes * Remove change from testing notes This requires AvaTax credentials for testing. So, we'll test for regressions instead * Check for null session before going forward (#8537) * Fix Payment Options settings crash in the editor (#8535) * Ensure express payment buttons are visible next to each other (#8548) * Update ZIP file * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Niels Lange <info@nielslange.de>

* Empty commit for release pull request * Add changelog to readme.txt * Unset default customer state if it doesn't match country (#8460) * Unset default state * add controller for customers * rename validation file * explain fix inline * address feedback * revert back state logic * Update src/StoreApi/Utilities/ValidationUtils.php Co-authored-by: Mike Jolley <mike.jolley@me.com> --------- Co-authored-by: Mike Jolley <mike.jolley@me.com> * Update readme.txt * Add testing notes * Update testing notes * Fix Customer account sidebar link incorrect margin in WP 6.2 (#8437) * Fix Customer account sidebar link incorrect margin in WP 6.2 * Update class name to match the guidelines * Prevent cart from breaking when item_data contains an array (#8440) * Ensure array item data is removed * Remove unused key * Clean up code and add comments * Check for null instead of empty * Use plain foreach to filter and map arrays * Add minimum height to Mini Cart Contents block in the Style Book (#8458) * Update testing notes zip file * Update testing notes * Update testing notes file * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * disable compatibilty layer (#8507) * update changelog and testing instructions * add zip link * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * Add changelog in readme.txt * Add testing notes * Remove change from testing notes This requires AvaTax credentials for testing. So, we'll test for regressions instead * Check for null session before going forward (#8537) * Fix Payment Options settings crash in the editor (#8535) * Ensure express payment buttons are visible next to each other (#8548) * Update ZIP file * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * Update readme.txt * Show three Express Payments buttons in-line (#8601) * Add testing notes * Bumping version strings to new version. * Empty commit for release pull request * Empty commit for release pull request * Add changelog in readme.txt * Undo dirty prop removal on error (#8633) Co-authored-by: Saad Tarhi <saad.trh@gmail.com> * Add testing notes * fix 404 error (#8445) * Empty commit for release pull request * add testing instruction * update zip link * fix version --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Niels Lange <info@nielslange.de>

Ensure express payment buttons are visible next to each other

35fd9a0

nielslange added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Feb 27, 2023

nielslange self-assigned this Feb 27, 2023

woocommercebot requested review from a team and opr and removed request for a team February 27, 2023 04:10

ralucaStan added the status: blocker Used on issues or pulls that block work from being released. label Feb 27, 2023

mikejolley approved these changes Feb 27, 2023

View reviewed changes

github-actions bot added this to the 9.7.0 milestone Feb 27, 2023

github-actions bot added the status: ready to merge label Feb 27, 2023

Merge branch 'trunk' into fix/8545-fix-inline-express-payment-buttons

e949ba5

nielslange merged commit 3153f4e into trunk Feb 27, 2023

nielslange deleted the fix/8545-fix-inline-express-payment-buttons branch February 27, 2023 10:30

github-actions bot removed the status: ready to merge label Feb 27, 2023

tarhi-saad modified the milestones: 9.7.0, 9.6.3 Feb 27, 2023

tarhi-saad pushed a commit that referenced this pull request Feb 27, 2023

Ensure express payment buttons are visible next to each other (#8548)

2fae767

tarhi-saad mentioned this pull request Feb 28, 2023

Bump WooCommerce blocks package to 9.6.3 woocommerce/woocommerce#36992

Merged

This was referenced Feb 28, 2023

Empty Express Payments list element rendered in Checkout block woocommerce/woocommerce-gateway-stripe#2558

Closed

Improve display logic of Express Payment buttons in Checkout block woocommerce/woocommerce#42464

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure express payment buttons are visible next to each other #8548

Ensure express payment buttons are visible next to each other #8548

nielslange commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

pierorocca commented Feb 27, 2023

mikejolley left a comment •

edited

Loading

nielslange commented Feb 27, 2023

malithsen commented Feb 27, 2023 •

edited

Loading

pierorocca commented Feb 27, 2023

pierorocca commented Feb 27, 2023

stephendharmadi commented Feb 28, 2023

Ensure express payment buttons are visible next to each other #8548

Ensure express payment buttons are visible next to each other #8548

Conversation

nielslange commented Feb 27, 2023 • edited Loading

Screenshots

Testing

User Facing Testing

WooCommerce Visibility

Changelog

github-actions bot commented Feb 27, 2023 • edited Loading

Script Dependencies Report

TypeScript Errors Report

github-actions bot commented Feb 27, 2023 • edited Loading

pierorocca commented Feb 27, 2023

mikejolley left a comment • edited Loading

Choose a reason for hiding this comment

nielslange commented Feb 27, 2023

malithsen commented Feb 27, 2023 • edited Loading

pierorocca commented Feb 27, 2023

pierorocca commented Feb 27, 2023

stephendharmadi commented Feb 28, 2023

nielslange commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

mikejolley left a comment •

edited

Loading

malithsen commented Feb 27, 2023 •

edited

Loading