This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Products]: Fix attributes filters that do not update the editor preview correctly #8611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: bug
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Mar 2, 2023
|
Added unit tests: commit. |
albarin
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When changing the attributes filter from the inspector controls, the products shown in the preview of Products block did not change accordingly.
Cause
The issue was caused by additional query component that extended the Products query:
$visibility_query(added here).Both:
$attributes_queryand$visibility_queryhave a shape of:array( 'tax_query' => [ ... ])so by passing
$visibility_queryto themerge_arraysfunction, the previoustax_query(from$attributes_query) was overridden by the new one and only the latter was passed further.Solution
The solution was to merge both
tax_queryparams into a single array.Fixes #8530
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog