This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add border support to mini cart contents #8654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +95 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
albarin
force-pushed
the
add/6257-border-support
branch
from
f205a47
to
13a9553
Compare
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
gigitux
approved these changes
Mar 8, 2023
| @@ -41,6 +41,10 @@ const settings: BlockConfiguration = { | |||
| link: true, | |||
| }, | |||
| lock: false, | |||
| __experimentalBorder: { | |||
There was a problem hiding this comment.
Is it correct that we enable this feature in WC Core too? I'm asking because it is an experimental API
There was a problem hiding this comment.
Yes, you are right, it shouldn't. I'll fix it. Thanks :)
There was a problem hiding this comment.
Pushed the fix, can you have another look? @gigitux
Aljullu
force-pushed
the
add/6257-border-support
branch
from
318eecb
to
e46216b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding border style controls to the Mini Cart overlay via the Mini Cart Contents block.
Fixes #6257
Screenshots
Testing
Automated Tests
User Facing Testing
Mini Cartblock to the header.Mini Carttemplate.Mini Cart contentsblock and check that in the settings sidebar you can see theBordercontrols.+button and add a border and save the template.Mini Cartbutton, and check you see the same border in the editor and in the frontend.WooCommerce Visibility
Changelog