This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Performance: Cache script data in a transient for production builds #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
the
type: cooldown
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
|
@mikejolley might be unrelated, but ran the E2E several times, and everytime all 5 failed. The errors are common flaky test output I've seen on other branches, but usually we don't get an 100% failure rate 🤔 |
mikejolley
force-pushed
the
performance/cache-asset-data-8796
branch
from
77638fe
to
bc6fb8e
Compare
|
Any ideas @wavvves ? I can't see anything that would break tests but clearly something is up :/ |
The output seems to have changed, and now has some complaints about undefined array entries bringing up the env. I have some urgent tasks to get going right now, but we can pair during this week on this 👍🏼 |
mikejolley
force-pushed
the
performance/cache-asset-data-8796
branch
3 times, most recently
from
8df495e
to
e17a317
Compare
|
Still can't work this out @wavvves Gonna leave it until next cooldown. |
I'm clueless also. Yes, after wrapping templates up, I'll assist on this during the cooldown and see what might be interfering with tests |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
Converting this PR to draft, feel free to revert once it's ready for review. |
mikejolley
force-pushed
the
performance/cache-asset-data-8796
branch
from
a33460d
to
74bf448
Compare
|
All fixed! Ready for review. |
mikejolley
added
status: needs review
and removed
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
mikejolley
removed
the
status: stale
wavvves
approved these changes
Jun 14, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
5 tasks
gigitux
added a commit
that referenced
this pull request
Aug 9, 2023
* Revert "Performance: Cache script data in a transient for production builds" (#10509) * Revert "Performance: Cache script data in a transient for production builds (#9120)" This reverts commit 6b9955d. * fix WordPress version * fix version * update version to 10.6.5 * update changelog and testing instructions * update zip link * fix changelog --------- Co-authored-by: Luigi Teschio <gigitux@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds caching to asset src, dependencies, and file version lookups to prevent the same data being requested on each page load. Values are stored in transients, and invalidated when the plugin package version increases. Development builds are excluded from caching to prevent issues when developing blocks.
Fixes #8796
Testing
Automated Tests
User Facing Testing
Mainly testing for regressions, so check that frontend scripts load correctly and existing blocks continue to function. Note; development builds do not use the cache.
npm run startfor a development build.npm run buildfor a production build.To see the contents of the transient, when running a production build (and assuming you are using WP Local), open database > adminer and check the wp_options table for the option named
_transient_woocommerce_blocks_asset_api_script_data. It should contain JSON containing the list of assets/dependencies etc.WooCommerce Visibility
Performance Impact
Positive; unsure how to get accurate metrics, but in limited testing with query monitor, a few seconds were shaved off of page load times. The original issue claimed 10% improvement.
Changelog