This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Cart/Checkout/Order-Received Templates #9301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavvves
added
block: cart
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/classic-template/index.tsx
assets/js/blocks/classic-template/test/utils.ts assets/js/editor-components/template-notice/index.tsx |
wavvves
changed the title
wavvves
added
needs: tests
|
Size Change: +2.69 kB (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
This was referenced May 1, 2023
This was
linked to
issues
May 1, 2023
wavvves
changed the title
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
wavvves
changed the title
mikejolley
previously requested changes
May 31, 2023
mikejolley
force-pushed
the
add/9288_cart-checkout-order-received_fse_templates
branch
2 times, most recently
from
43b9f6f to
7592eec
Compare
nielslange
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Thanks for working on this, @wavvves and @mikejolley. The changes work as expected on my end.
ralucaStan
reviewed
Jun 20, 2023
…SE theme (#9339) * Introduce woocommerce_blocks_template_content hook * Migrate cart and checkout page content to the template editor * Add redirection from edit page to edit template --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
* Removed header and footer from checkout template. * Removed header and footer from checkout template migration
* Checkout endpoint work * Move setting field to util * Include link to edit the template * Remove todo * Refactor checkout templates to share logic (#9411) * Sync endpoints with pages (#9426) * Switch to page syncing * Update settings descriptions --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
* Migrate content on init, once * Skip migration if page does not exist * Put back HTML for header and footer parts * Fix page redirect due to wrong ID * fix loading template part * Removed unnecessary var * update cart and checkout html templates --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
* Load frontend styles in editor iframe * Update placeholder to include skeleton and updated icons * Update classic template configs * 1px border for .wp-block-woocommerce-classic-template__placeholder-copy * Show copy on focus * Sample data --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
* Added simplified header on checkout template * Moved simplified header to template part * updated constants.ts * added template part to checkout.html
* rebrand order received to order confirmation * updated descriptions for templates * updated descriptions for order confirmation placeholder
* Merge branch 'trunk' into poc/cart_and_checkout_fse_templates * Merge branch 'trunk' into add/9288_cart-checkout-order-received_fse_templates * Resolve merge conflicts * Add e2e for permalink settings * Test that templates exist * Add test to check that templates can be edited * Add tests to confirm templates can be edited * Ensure cart has contents before running tests on frontend views * Commend out problem test * Make sure search has multiple results * Remove useThrottle - bad rebase * Revert changes to docs after rebase * Revert function call for noReviewsPlaceholder * Bad rebase * Reverts * Remove revertTemplate * Spacing * Wait for networkidle after navigation * Always wait for network * Use button roles in site editor * More specific button locator * Update option comparison * Fix template content * Disable failing tests * Disable failing classic template tests * Use enterEditMode * More enterEditMode usage * enterEditMode * Use test.skip * More robust selectors * Alt iframe selector --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
mikejolley
force-pushed
the
add/9288_cart-checkout-order-received_fse_templates
branch
from
6207faf to
8881473
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at introducing Cart, Checkout and Order Confirmation templates.
We implement changes for Cart and Checkout in permalink management, that are now handled via
WooCommerce > Settings > Advancedreplacing the previous system based on selecting handling pages. We also migrate the current contents for Cart and Checkout that enables a user to maintain his checkout flow experience when enabling a blocks theme. The default Checkout template uses a new template part, Checkout Header, offering a more distraction free view.For Order Confirmation we will render the defined classic template as part of the view, therefore implementing any actions and filters present on it, making it compatible to any extensions that may make use of them. As part of the phased approach, we will present a placeholder on the editor. The inner elements will not be editable for now.
Fixes #9288
Fixes #9153
Fixes #9165
Replaces #8350 and #8937
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog