This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent QuantitySelector stealing focus on page load #9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +87 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Aljullu
added
the
status: blocker
thealexandrelara
approved these changes
May 17, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9345 I introduced a regression: when opening the Cart page, if a product quantity couldn't be decreased, the quantity input was getting the focus. This PR fixes it, making sure we only move the focus to the input field when the decrease/increase button changes from enabled to disabled.
For context: moving the focus was required to make sure the Mini Cart drawer was closing when a button which had focused changed from enabled to disabled.
Testing
User Facing Testing
WooCommerce Visibility